Enhancements to Release Bundle Create Command: Optional Flags and Fallback Support #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
oshratZairi
force-pushed
the
optionalSpec
branch
from
6e7bcf1 to
5fe48da
Compare
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
oshratZairi
force-pushed
the
optionalSpec
branch
from
5fe48da to
bc2fd42
Compare
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
oshratZairi
force-pushed
the
optionalSpec
branch
from
bc2fd42 to
267e7d1
Compare
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
oshratZairi
force-pushed
the
optionalSpec
branch
from
267e7d1 to
57f6280
Compare
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
oshratZairi
force-pushed
the
optionalSpec
branch
from
57f6280 to
d737680
Compare
oshratZairi
had a problem deploying
to
frogbot
GitHub Actions
Failure
eyalbe4
requested changes
Dec 2, 2024
utils/cliutils/commandsflags.go
Outdated
Comment on lines
582
to
583
| BuildName = "build-name" | ||
| BuildNumber = "build-number" |
There was a problem hiding this comment.
No need to define the above two consts.
You should reuse the existing buildName and buildNumber consts defined above.
oshratZairi
force-pushed
the
optionalSpec
branch
from
0133b7b to
f2255a0
Compare
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
oshratZairi
force-pushed
the
optionalSpec
branch
from
f2255a0 to
0c0792f
Compare
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
oshratZairi
force-pushed
the
optionalSpec
branch
from
0c0792f to
94767c5
Compare
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Dec 4, 2024
Comment on lines
+83
to
+85
| t.Setenv("JFROG_CLI_BUILD_NAME", "Common-builds") | ||
| t.Setenv("JFROG_CLI_BUILD_NUMBER", "2.0.0") |
There was a problem hiding this comment.
When test functions set env vars, they must also remove them at the end. There's already a tulity function in the code that takes care of this. Check other tests asa reference.
There was a problem hiding this comment.
The way you set the variables is unsafe. You should use the SetEnvWithCallbackAndAssert API.
oshratZairi
force-pushed
the
optionalSpec
branch
from
f1e827c to
4745631
Compare
oshratZairi
force-pushed
the
optionalSpec
branch
from
4745631 to
fd666de
Compare
lesnerd
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
pushed a commit
to eyalbe4/jfrog-cli
that referenced
this pull request
Dec 8, 2024
… and Fallback Support (jfrog#2772)" This reverts commit a124f63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Improvements to the release bundle create command:
specflag optional, withbuild-nameandbuild-numberflags as replacements.JFROG_CLI_BUILD_NAMEandJFROG_CLI_BUILD_NUMBERas fallback options when thebuild-nameandbuild-numberflags are not provided.documentation - https://github.com/jfrog/documentation/pull/173/files