Enhance download functionality to support RBV2 #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshratZairi
force-pushed
the
downloadRbv2
branch
from
004bebb to
935dc22
Compare
oshratZairi
force-pushed
the
downloadRbv2
branch
from
935dc22 to
5eddf64
Compare
EyalDelarea
requested changes
Dec 31, 2024
artifactory/cli.go
Outdated
| if c.IsSet("bundle") { | ||
| isRbv2, err = checkRbExistenceInV2(c) | ||
| } | ||
| //if the command contains --bundle and the bundle found in rbv2, we will download from rbv2 |
There was a problem hiding this comment.
What happens when the bundle is not in V2? the download commands continues as it as?
And also this is a generic download code with too much RBV2 references, maybe we should extract some logic to a one liner function to avoid it.
I would move this logic inside the prepareDownloadCommand.
There was a problem hiding this comment.
the logic is:
if we have the same rb-name in both rbv1 and rbv2 - we will take rbv2.
if the cmd dose not contain --bundle , it will remain as it is.
moved the logic.
go.mod
Outdated
| @@ -168,6 +168,10 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/jfrog/jfrog-cli-core/v2 => ../jfrog-cli-core | |||
There was a problem hiding this comment.
Notice to change replaces before pushing :)
oshratZairi
force-pushed
the
downloadRbv2
branch
from
5eddf64 to
eafc54a
Compare
oshratZairi
force-pushed
the
downloadRbv2
branch
from
eafc54a to
7d9b52b
Compare
oshratZairi
force-pushed
the
downloadRbv2
branch
from
7d9b52b to
c28b293
Compare
oshratZairi
force-pushed
the
downloadRbv2
branch
from
a94debd to
4212def
Compare
oshratZairi
force-pushed
the
downloadRbv2
branch
from
4212def to
1f1b004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Enhance download functionality to support RBV2