-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Minor Version Tagging #228
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
I tested the automatic release functionality in my forked repo and it works the same and manually creating a Release with generated release notes. |
recheck |
@EyalDelarea I'm not sure how to request reviewer(s) |
@eyalbe4 I'm not sure how to request reviewer(s) |
@RobiNino could you please review / add reviewers on my behalf? |
@sverdlov93 Are public users allowed to propose these types of changes? I don't think I've missed any steps in the contributing guidelines |
@EyalDelarea @eyalb4doc @RobiNino @sverdlov93 Is this a welcome change? Maybe you guys have some insight on a different way to approach this? |
Hi @hazeltonl, Thank you for your contribution! We appreciate your effort, but unfortunately, automating releases isn’t a suitable approach for our workflow. Since this action is customer-facing, we usually prefer to edit the release notes before publishing. Editing them after release isn't ideal for us because customers are notified immediately. That said, adding minor version tagging is a great improvement. If you'd like to adjust your PR to include only the minor tagging feature, I’d be happy to review it. Thank you again for your support! |
@EyalDelarea that makes total sense! Easy change then, already pushed :) |
Co-authored-by: Eyal Delarea <[email protected]>
npm run format
for formatting the code before submitting the pull request.PR Description: Enable Versioning by Minor Versions for [email protected]
This update introduces support for specifying minor versions of the action. Previously, you could only use
action@v4
to point to the latest release of the major versionv4
. With this change, you can now pin your workflow to specific minor versions, offering greater flexibility and stability.What’s New:
[email protected]
to use the latest minor version ofv4
.How to Use:
To use this feature, simply replace
action@v4
with[email protected]
in your GitHub Actions workflows. This change ensures that your workflows will continue using the latest patch updates within the specified minor version.Example 1: Using
action@v4
for the latest major version (before the update):Example 2: Pinning to the latest minor version of v4 (
v4.x
):With this configuration, GitHub Actions will use the latest minor release of
v4
, ensuring your workflow remains stable within the same major version while benefiting from any fixes or improvements within the minor version.Why This is Useful:
Example Use Case:
If you want to lock your workflow to the latest release of version 4, but ensure it doesn't automatically upgrade to a future major version (like
v5
), you can now use:This ensures you're always using the latest features and bug fixes within the
v4
series without risking breaking changes from a new major release.