Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Minor Version Tagging #228

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

hazeltonl
Copy link
Contributor

@hazeltonl hazeltonl commented Nov 20, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

PR Description: Enable Versioning by Minor Versions for [email protected]

This update introduces support for specifying minor versions of the action. Previously, you could only use action@v4 to point to the latest release of the major version v4. With this change, you can now pin your workflow to specific minor versions, offering greater flexibility and stability.

What’s New:

  • Minor version tagging: You can now specify versions such as [email protected] to use the latest minor version of v4.
  • This allows you to fix your workflow to a specific minor version and benefit from bug fixes or improvements within that minor version without automatically upgrading to a new major version.

How to Use:

To use this feature, simply replace action@v4 with [email protected] in your GitHub Actions workflows. This change ensures that your workflows will continue using the latest patch updates within the specified minor version.

Example 1: Using action@v4 for the latest major version (before the update):

uses: actions/action-name@v4

Example 2: Pinning to the latest minor version of v4 (v4.x):

uses: actions/[email protected]

With this configuration, GitHub Actions will use the latest minor release of v4, ensuring your workflow remains stable within the same major version while benefiting from any fixes or improvements within the minor version.

Why This is Useful:

  • Improved Stability: You can now be more specific about the version you're using, preventing unexpected updates that might come with new major releases.
  • Flexible Upgrades: This allows for smoother upgrades when minor version improvements are made without jumping to a new major version.

Example Use Case:

If you want to lock your workflow to the latest release of version 4, but ensure it doesn't automatically upgrade to a future major version (like v5), you can now use:

uses: actions/[email protected]

This ensures you're always using the latest features and bug fixes within the v4 series without risking breaking changes from a new major release.

Copy link

github-actions bot commented Nov 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hazeltonl
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hazeltonl
Copy link
Contributor Author

recheck

@hazeltonl
Copy link
Contributor Author

hazeltonl commented Nov 20, 2024

I tested the automatic release functionality in my forked repo and it works the same and manually creating a Release with generated release notes.

@hazeltonl hazeltonl changed the title Add Moving Minor Version Tag Automate More Complete Release Process Nov 20, 2024
@hazeltonl
Copy link
Contributor Author

recheck

@hazeltonl
Copy link
Contributor Author

@EyalDelarea I'm not sure how to request reviewer(s)

@hazeltonl
Copy link
Contributor Author

@eyalbe4 I'm not sure how to request reviewer(s)

@hazeltonl hazeltonl mentioned this pull request Dec 5, 2024
2 tasks
@hazeltonl
Copy link
Contributor Author

@RobiNino could you please review / add reviewers on my behalf?

@hazeltonl
Copy link
Contributor Author

@sverdlov93 Are public users allowed to propose these types of changes? I don't think I've missed any steps in the contributing guidelines

@hazeltonl
Copy link
Contributor Author

@EyalDelarea @eyalb4doc @RobiNino @sverdlov93 Is this a welcome change? Maybe you guys have some insight on a different way to approach this?

@EyalDelarea
Copy link
Contributor

Hi @hazeltonl,

Thank you for your contribution!

We appreciate your effort, but unfortunately, automating releases isn’t a suitable approach for our workflow. Since this action is customer-facing, we usually prefer to edit the release notes before publishing. Editing them after release isn't ideal for us because customers are notified immediately.

That said, adding minor version tagging is a great improvement. If you'd like to adjust your PR to include only the minor tagging feature, I’d be happy to review it.

Thank you again for your support!

@hazeltonl
Copy link
Contributor Author

@EyalDelarea that makes total sense! Easy change then, already pushed :)

.github/workflows/release.yml Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Jan 7, 2025
@EyalDelarea EyalDelarea changed the title Automate More Complete Release Process Support Minor Version Tagging Jan 7, 2025
@EyalDelarea EyalDelarea merged commit 6bae8d8 into jfrog:master Jan 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants