You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For applications in proofreading and meshing it's useful to have a way to get the cuboids that specifically belong to one ID. This functionality existed as an intermediate product of indexing and bounding boxes, so I just yanked some of that code to create a cuboid_from_id() function that returns the list of cuboid corners that contain a particular ID.
This PR adds the URL and View functions in Django. The URL is formatted in this way: {base_url}/v1/cuboidsfromid/:collection/:experiment:/channel/:resolution/:id
As an end-user, I think it would make sense for either this endpoint or another to also tell me the cuboid size. We've been consistent with our cuboid sizes historically, but there's no reason for an end-user to know what it is a priori.
As an end-user, I think it would make sense for either this endpoint or another to also tell me the cuboid size. We've been consistent with our cuboid sizes historically, but there's no reason for an end-user to know what it is a priori.
Good point, especially since we are planning to add that other storage type soon. 😄
As an end-user, I think it would make sense for either this endpoint or another to also tell me the cuboid size. We've been consistent with our cuboid sizes historically, but there's no reason for an end-user to know what it is a priori.
Good point, especially since we are planning to add that other storage type soon. 😄
Thinking it should be part of a different endpoint since this requires datasets to be indexed and cuboid sizes matters for non-indexed datasets as well. Could add it to channel info probably?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR because I haven't added tests.
For applications in proofreading and meshing it's useful to have a way to get the cuboids that specifically belong to one ID. This functionality existed as an intermediate product of indexing and bounding boxes, so I just yanked some of that code to create a cuboid_from_id() function that returns the list of cuboid corners that contain a particular ID.
This PR adds the URL and View functions in Django. The URL is formatted in this way:
{base_url}/v1/cuboidsfromid/:collection/:experiment:/channel/:resolution/:idSPDB PR: jhuapl-boss/spdb#28