Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not update refresh token on session refresh, if empty #341

Merged
merged 15 commits into from
Nov 8, 2024
Merged

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Nov 1, 2024

What this PR does / why we need it

Fixes #338

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

@jkroepke jkroepke added the 🐞 bug Something isn't working label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 76.41509% with 50 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (1dc2a22) to head (c0de6ee).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/oauth2/handler.go 40.62% 14 Missing and 5 partials ⚠️
internal/oauth2/refresh.go 32.00% 15 Missing and 2 partials ⚠️
internal/openvpn/callbacks.go 64.70% 6 Missing ⚠️
internal/storage/storage.go 58.33% 4 Missing and 1 partial ⚠️
internal/openvpn/client.go 97.01% 2 Missing ⚠️
internal/oauth2/providers/generic/oidc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   82.50%   81.80%   -0.70%     
==========================================
  Files          50       51       +1     
  Lines        3081     3150      +69     
==========================================
+ Hits         2542     2577      +35     
- Misses        408      437      +29     
- Partials      131      136       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke jkroepke force-pushed the reauth branch 2 times, most recently from 832f50c to 49e962f Compare November 1, 2024 16:46
@jkroepke jkroepke force-pushed the reauth branch 2 times, most recently from 9a3ffd5 to 9fe74b1 Compare November 2, 2024 16:21
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke and others added 6 commits November 8, 2024 11:00
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke enabled auto-merge (squash) November 8, 2024 18:38
@jkroepke jkroepke merged commit e0da4f2 into main Nov 8, 2024
7 checks passed
@jkroepke jkroepke deleted the reauth branch November 8, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing required parameter: refresh_token
1 participant