Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oauth2 PKCE and nonce validation #99

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Implement oauth2 PKCE and nonce validation #99

merged 7 commits into from
Dec 28, 2023

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke added the chore small nits label Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (f2354f7) 76.03% compared to head (4a9a73d) 76.89%.

❗ Current head 4a9a73d differs from pull request most recent head f3153c4. Consider uploading reports for the commit f3153c4 to get more accurate results

Files Patch % Lines
internal/oauth2/handler.go 50.76% 25 Missing and 7 partials ⚠️
internal/oauth2/provider.go 75.55% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   76.03%   76.89%   +0.86%     
==========================================
  Files          37       37              
  Lines        1936     1978      +42     
==========================================
+ Hits         1472     1521      +49     
+ Misses        391      385       -6     
+ Partials       73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke added ✨ enhancement New feature or request and removed chore small nits labels Dec 27, 2023
@jkroepke jkroepke changed the title Increase test coverage Implement oauth2 PKCE and nonce validation Dec 27, 2023
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke enabled auto-merge (squash) December 28, 2023 01:12
@jkroepke jkroepke merged commit 3106684 into main Dec 28, 2023
8 checks passed
@jkroepke jkroepke deleted the testcov branch December 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant