Do not set undefined time zone for copy from string (log2timeline#277)

joachimmetz · Feb 23, 2024 · f9247c6 · f9247c6
1 parent e092d3b
commit f9247c6
Show file tree

Hide file tree

Showing 36 changed files with 129 additions and 130 deletions.
diff --git a/.github/workflows/test_docker.yml b/.github/workflows/test_docker.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: ['38']
+        version: ['39']
     container:
       image: registry.fedoraproject.org/fedora:${{ matrix.version }}
     steps:

diff --git a/config/dpkg/changelog b/config/dpkg/changelog
@@ -1,5 +1,5 @@
-dfdatetime (20240210-1) unstable; urgency=low
+dfdatetime (20240220-1) unstable; urgency=low
 
   * Auto-generated
 
- -- Log2Timeline maintainers <[email protected]>  Sat, 10 Feb 2024 07:26:17 +0100
+ -- Log2Timeline maintainers <[email protected]>  Tue, 20 Feb 2024 19:10:25 +0100
diff --git a/dfdatetime/__init__.py b/dfdatetime/__init__.py
@@ -25,4 +25,4 @@
 from dfdatetime import webkit_time
 
 
-__version__ = '20240210'
+__version__ = '20240220'
diff --git a/dfdatetime/cocoa_time.py b/dfdatetime/cocoa_time.py
@@ -94,7 +94,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

diff --git a/dfdatetime/delphi_date_time.py b/dfdatetime/delphi_date_time.py
@@ -99,7 +99,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year > 9999:
       raise ValueError(f'Unsupported year value: {year:d}.')

diff --git a/dfdatetime/dotnet_datetime.py b/dfdatetime/dotnet_datetime.py
@@ -95,7 +95,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year > 9999:
       raise ValueError(f'Unsupported year value: {year:d}.')

diff --git a/dfdatetime/fake_time.py b/dfdatetime/fake_time.py
@@ -82,7 +82,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', None)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     self._normalized_timestamp = None
     self._number_of_seconds = self._GetNumberOfSecondsFromElements(

diff --git a/dfdatetime/fat_date_time.py b/dfdatetime/fat_date_time.py
@@ -155,7 +155,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 1980 or year > (1980 + 0x7f):
       raise ValueError(f'Year value not supported: {year!s}.')
@@ -266,7 +266,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 1980 or year > (1980 + 0x7f):
       raise ValueError(f'Year value not supported: {year!s}.')

diff --git a/dfdatetime/filetime.py b/dfdatetime/filetime.py
@@ -99,7 +99,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 1601:
       raise ValueError(f'Year value not supported: {year!s}.')

diff --git a/dfdatetime/golang_time.py b/dfdatetime/golang_time.py
@@ -176,7 +176,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 0:
       raise ValueError(f'Year value not supported: {year!s}.')

diff --git a/dfdatetime/hfs_time.py b/dfdatetime/hfs_time.py
@@ -95,7 +95,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 1904 or year > 2040:
       raise ValueError('Year value not supported.')

diff --git a/dfdatetime/ole_automation_date.py b/dfdatetime/ole_automation_date.py
@@ -100,7 +100,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

diff --git a/dfdatetime/posix_time.py b/dfdatetime/posix_time.py
@@ -90,7 +90,7 @@ def CopyFromDateTimeString(self, time_string):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     self._timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)
@@ -188,7 +188,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MILLISECOND)
@@ -294,7 +294,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MICROSECOND)
@@ -400,7 +400,7 @@ def _CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     timestamp = self._GetNumberOfSecondsFromElements(
         year, month, day_of_month, hours, minutes, seconds)

diff --git a/dfdatetime/rfc2579_date_time.py b/dfdatetime/rfc2579_date_time.py
@@ -209,7 +209,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     deciseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_DECISECOND)

diff --git a/dfdatetime/systemtime.py b/dfdatetime/systemtime.py
@@ -184,7 +184,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     milliseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MILLISECOND)

diff --git a/dfdatetime/time_elements.py b/dfdatetime/time_elements.py
@@ -358,7 +358,7 @@ def _CopyFromDateTimeValues(self, date_time_values):
     hours = date_time_values.get('hours', 0)
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     self._normalized_timestamp = None
     self._number_of_seconds = self._GetNumberOfSecondsFromElements(
@@ -954,7 +954,7 @@ def _CopyFromDateTimeValues(self, date_time_values):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     precision_helper = precisions.PrecisionHelperFactory.CreatePrecisionHelper(
         self._precision)

diff --git a/dfdatetime/uuid_time.py b/dfdatetime/uuid_time.py
@@ -105,7 +105,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     if year < 1582:
       raise ValueError('Year value not supported.')

diff --git a/dfdatetime/webkit_time.py b/dfdatetime/webkit_time.py
@@ -96,7 +96,7 @@ def CopyFromDateTimeString(self, time_string):
     minutes = date_time_values.get('minutes', 0)
     seconds = date_time_values.get('seconds', 0)
     nanoseconds = date_time_values.get('nanoseconds', 0)
-    time_zone_offset = date_time_values.get('time_zone_offset', 0)
+    time_zone_offset = date_time_values.get('time_zone_offset', None)
 
     microseconds, _ = divmod(
         nanoseconds, definitions.NANOSECONDS_PER_MICROSECOND)

diff --git a/docs/sources/Date-and-time-values.md b/docs/sources/Date-and-time-values.md
@@ -205,8 +205,7 @@ Supported date range | 1601-01-01 00:00:00.0000000 through ...
 Storage granularity | 100-nanosecond intervals
 Time zone | externally represented, typically UTC
 
-The actual upper bound of the supported date range is unclear. Also see:
-[Latest possible FILETIME](https://stackoverflow.com/questions/9999393/latest-possible-filetime)
+The actual upper bound of the supported date range is unclear.
 
 ### Format
 

diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = dfdatetime
-version = 20240210
+version = 20240220
 description = Digital Forensics date and time (dfDateTime).
 long_description = dfDateTime, or Digital Forensics date and time, provides date and time objects to preserve accuracy and precision.
 long_description_content_type = text/plain

diff --git a/tests/cocoa_time.py b/tests/cocoa_time.py
@@ -60,15 +60,15 @@ def testCopyFromDateTimeString(self):
 
     cocoa_time_object.CopyFromDateTimeString('2013-07-08')
     self.assertEqual(cocoa_time_object._timestamp, 394934400.0)
-    self.assertEqual(cocoa_time_object._time_zone_offset, 0)
+    self.assertEqual(cocoa_time_object._time_zone_offset, None)
 
     cocoa_time_object.CopyFromDateTimeString('2013-07-08 21:30:45')
     self.assertEqual(cocoa_time_object._timestamp, 395011845.0)
-    self.assertEqual(cocoa_time_object._time_zone_offset, 0)
+    self.assertEqual(cocoa_time_object._time_zone_offset, None)
 
     cocoa_time_object.CopyFromDateTimeString('2013-07-08 21:30:45.546875')
     self.assertEqual(cocoa_time_object._timestamp, 395011845.546875)
-    self.assertEqual(cocoa_time_object._time_zone_offset, 0)
+    self.assertEqual(cocoa_time_object._time_zone_offset, None)
 
     cocoa_time_object.CopyFromDateTimeString('2013-07-08 21:30:45.546875-01:00')
     self.assertEqual(cocoa_time_object._timestamp, 395011845.546875)
@@ -80,7 +80,7 @@ def testCopyFromDateTimeString(self):
 
     cocoa_time_object.CopyFromDateTimeString('2001-01-02 00:00:00')
     self.assertEqual(cocoa_time_object._timestamp, 86400.0)
-    self.assertEqual(cocoa_time_object._time_zone_offset, 0)
+    self.assertEqual(cocoa_time_object._time_zone_offset, None)
 
   def testCopyToDateTimeString(self):
     """Tests the CopyToDateTimeString function."""

diff --git a/tests/delphi_date_time.py b/tests/delphi_date_time.py
@@ -100,15 +100,15 @@ def testCopyFromDateTimeString(self):
 
     delphi_date_time_object.CopyFromDateTimeString('2013-06-18')
     self.assertEqual(delphi_date_time_object._timestamp, 41443.0)
-    self.assertEqual(delphi_date_time_object._time_zone_offset, 0)
+    self.assertEqual(delphi_date_time_object._time_zone_offset, None)
 
     delphi_date_time_object.CopyFromDateTimeString('2013-06-18 19:50:00')
     self.assertEqual(delphi_date_time_object._timestamp, 41443.82638888889)
-    self.assertEqual(delphi_date_time_object._time_zone_offset, 0)
+    self.assertEqual(delphi_date_time_object._time_zone_offset, None)
 
     delphi_date_time_object.CopyFromDateTimeString('2013-06-18 19:50:00.546875')
     self.assertEqual(delphi_date_time_object._timestamp, 41443.826395218464)
-    self.assertEqual(delphi_date_time_object._time_zone_offset, 0)
+    self.assertEqual(delphi_date_time_object._time_zone_offset, None)
 
     delphi_date_time_object.CopyFromDateTimeString(
         '2013-06-18 19:50:00.546875-01:00')
@@ -122,7 +122,7 @@ def testCopyFromDateTimeString(self):
 
     delphi_date_time_object.CopyFromDateTimeString('1899-12-31 00:00:00')
     self.assertEqual(delphi_date_time_object._timestamp, 1.0)
-    self.assertEqual(delphi_date_time_object._time_zone_offset, 0)
+    self.assertEqual(delphi_date_time_object._time_zone_offset, None)
 
     delphi_date_time_object = DelphiDateTimeInvalidYear()
 

diff --git a/tests/dotnet_datetime.py b/tests/dotnet_datetime.py
@@ -64,15 +64,15 @@ def testCopyFromDateTimeString(self):
 
     dotnet_date_time.CopyFromDateTimeString('2020-12-12')
     self.assertEqual(dotnet_date_time._timestamp, 637433280000000000)
-    self.assertEqual(dotnet_date_time._time_zone_offset, 0)
+    self.assertEqual(dotnet_date_time._time_zone_offset, None)
 
     dotnet_date_time.CopyFromDateTimeString('2020-12-12 12:12:12')
     self.assertEqual(dotnet_date_time._timestamp, 637433719320000000)
-    self.assertEqual(dotnet_date_time._time_zone_offset, 0)
+    self.assertEqual(dotnet_date_time._time_zone_offset, None)
 
     dotnet_date_time.CopyFromDateTimeString('2020-12-12 12:12:12.123')
     self.assertEqual(dotnet_date_time._timestamp, 637433719321230000)
-    self.assertEqual(dotnet_date_time._time_zone_offset, 0)
+    self.assertEqual(dotnet_date_time._time_zone_offset, None)
 
   def testCopyToDateTimeString(self):
     """Tests the CopyToDateTimeString function."""

diff --git a/tests/fake_time.py b/tests/fake_time.py
@@ -55,17 +55,17 @@ def testCopyFromDateTimeString(self):
     fake_time_object.CopyFromDateTimeString('2010-08-12')
     self.assertEqual(fake_time_object._number_of_seconds, 1281571200)
     self.assertIsNone(fake_time_object._microseconds)
-    self.assertEqual(fake_time_object._time_zone_offset, 0)
+    self.assertEqual(fake_time_object._time_zone_offset, None)
 
     fake_time_object.CopyFromDateTimeString('2010-08-12 21:06:31')
     self.assertEqual(fake_time_object._number_of_seconds, 1281647191)
     self.assertIsNone(fake_time_object._microseconds)
-    self.assertEqual(fake_time_object._time_zone_offset, 0)
+    self.assertEqual(fake_time_object._time_zone_offset, None)
 
     fake_time_object.CopyFromDateTimeString('2010-08-12 21:06:31.546875')
     self.assertEqual(fake_time_object._number_of_seconds, 1281647191)
     self.assertEqual(fake_time_object._microseconds, 546875)
-    self.assertEqual(fake_time_object._time_zone_offset, 0)
+    self.assertEqual(fake_time_object._time_zone_offset, None)
 
     fake_time_object.CopyFromDateTimeString('2010-08-12 21:06:31.546875-01:00')
     self.assertEqual(fake_time_object._number_of_seconds, 1281647191)
@@ -80,7 +80,7 @@ def testCopyFromDateTimeString(self):
     fake_time_object.CopyFromDateTimeString('1601-01-02 00:00:00')
     self.assertEqual(fake_time_object._number_of_seconds, -11644387200)
     self.assertIsNone(fake_time_object._microseconds)
-    self.assertEqual(fake_time_object._time_zone_offset, 0)
+    self.assertEqual(fake_time_object._time_zone_offset, None)
 
   def testCopyToDateTimeString(self):
     """Tests the CopyToDateTimeString function."""

diff --git a/tests/fat_date_time.py b/tests/fat_date_time.py
@@ -52,15 +52,15 @@ def testCopyFromDateTimeString(self):
 
     fat_date_time_object.CopyFromDateTimeString('2010-08-12')
     self.assertEqual(fat_date_time_object._number_of_seconds, 966038400)
-    self.assertEqual(fat_date_time_object._time_zone_offset, 0)
+    self.assertEqual(fat_date_time_object._time_zone_offset, None)
 
     fat_date_time_object.CopyFromDateTimeString('2010-08-12 21:06:31')
     self.assertEqual(fat_date_time_object._number_of_seconds, 966114391)
-    self.assertEqual(fat_date_time_object._time_zone_offset, 0)
+    self.assertEqual(fat_date_time_object._time_zone_offset, None)
 
     fat_date_time_object.CopyFromDateTimeString('2010-08-12 21:06:31.546875')
     self.assertEqual(fat_date_time_object._number_of_seconds, 966114391)
-    self.assertEqual(fat_date_time_object._time_zone_offset, 0)
+    self.assertEqual(fat_date_time_object._time_zone_offset, None)
 
     fat_date_time_object.CopyFromDateTimeString(
         '2010-08-12 21:06:31.546875-01:00')
@@ -74,7 +74,7 @@ def testCopyFromDateTimeString(self):
 
     fat_date_time_object.CopyFromDateTimeString('1980-01-02 00:00:00')
     self.assertEqual(fat_date_time_object._number_of_seconds, 86400)
-    self.assertEqual(fat_date_time_object._time_zone_offset, 0)
+    self.assertEqual(fat_date_time_object._time_zone_offset, None)
 
     with self.assertRaises(ValueError):
       fat_date_time_object.CopyFromDateTimeString('2200-01-02 00:00:00')
@@ -204,15 +204,15 @@ def testCopyFromDateTimeString(self):
 
     fat_timestamp_object.CopyFromDateTimeString('2021-07-09')
     self.assertEqual(fat_timestamp_object._timestamp, 131025600000)
-    self.assertEqual(fat_timestamp_object._time_zone_offset, 0)
+    self.assertEqual(fat_timestamp_object._time_zone_offset, None)
 
     fat_timestamp_object.CopyFromDateTimeString('2021-07-09 22:11:30')
     self.assertEqual(fat_timestamp_object._timestamp, 131033589000)
-    self.assertEqual(fat_timestamp_object._time_zone_offset, 0)
+    self.assertEqual(fat_timestamp_object._time_zone_offset, None)
 
     fat_timestamp_object.CopyFromDateTimeString('2021-07-09 22:11:30.246875')
     self.assertEqual(fat_timestamp_object._timestamp, 131033589024)
-    self.assertEqual(fat_timestamp_object._time_zone_offset, 0)
+    self.assertEqual(fat_timestamp_object._time_zone_offset, None)
 
     fat_timestamp_object.CopyFromDateTimeString(
         '2021-07-09 22:11:30.246875-01:00')
@@ -226,7 +226,7 @@ def testCopyFromDateTimeString(self):
 
     fat_timestamp_object.CopyFromDateTimeString('1980-01-02 00:00:00')
     self.assertEqual(fat_timestamp_object._timestamp, 8640000)
-    self.assertEqual(fat_timestamp_object._time_zone_offset, 0)
+    self.assertEqual(fat_timestamp_object._time_zone_offset, None)
 
     with self.assertRaises(ValueError):
       fat_timestamp_object.CopyFromDateTimeString('2200-01-02 00:00:00')
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,4 +25,4 @@
		from dfdatetime import webkit_time


		__version__ = '20240210'
		__version__ = '20240220'