-
Notifications
You must be signed in to change notification settings - Fork 353
Add LDAP auth support #1211
base: master
Are you sure you want to change the base?
Add LDAP auth support #1211
Conversation
Please rebase this on the |
|
OK, I'll try to update the PR as soon as I have some spare time :-) |
Sorry, wrong push on my fork closed this PR, so reopening. I could rebase but the pipenv commands do not change anything in requirements.txt. |
I've added the missing dependencies to the Dockerfile and in ansible/tasks/main.yml (libldap2-dev and libsasl2-dev), now the ansible test is passing, but the build-release is still failing. Where should I specify those dependencies for the build to succeed ? |
any hint ? |
@dani I looked at the build log, and it appears that the ldap development packages need to be added to the apt package install list. I would try adding these, and see if the build then completes.
|
But where's this list defined ? Is it the one in the Dockerfile or elsewhere ? |
The portion of the build that's failing appears to be docker, so yes, it should be the list in the Dockerfile. |
Looks like it's still failing on the lber.h (which should be installed with libldap2-dev)... |
Hello I use paperless-ng and want to integrate it in app catalog of the project YunoHost, but for better support they require to have LDAP support. Can this PR be more under development please |
I'd like to go foward but I really have no idea why is the test build failing. |
I think it’s because you need this |
Are you sure the CI have this ? |
Here you can find some answer |
Well, I've added the dependencies in the Dockerfile. If they have to be specified somewhere else, I have no idea where |
I dont see Also error with, so i think you should mention project maintainer may he will can help you better |
@dani in the .github/workflows/ci.yaml directory you'll probably need to add the dependencies as well Line 188 and following ones I'd guess |
Looks like the build is now successful. Only the test coverage slightly decreased. Is this enough for the PR to be merged ? |
Would be great having this feature :) |
Update? |
Puh-leeez? :) |
Yea... Waiting on this before I can do a rollout of it to my family... |
I would love to test this feature :) |
I needed LDAP auth to use paperless (which I'm evaluating as a personal document management system), so, I've hacked it. It's pretty basic, only support users (not groups or fancy searches) but should fit most needs. Tested against a samba4 (AD style) directory only, but should work with most directories