This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Remove alpha layer from PNG files for img2pdf #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @muellermartin, this repo appears to be abandoned. I'd encourage you to open your PR in the Paperless revival project, paperless-ngx. |
|
@qcasey Oh, thanks for the hint. I will submit the PR there again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PNG file with an alpha layer is loaded in paperless-ng, the upload fails with an
UnsupportedImageFormatError()although PNG files are generally supported. The error comes from OCRmyPDF (line 76 in src/ocrmypdf/_pipeline.py) which in turn tries to fulfill the requirements for img2pdf.img2pdf states that it is meant for lossless conversion and thus does not want alter the input images (e.g. by removing the alpha layer) for conversion.
This PR checks if input images have an alpha layer and removes it by blending it with a white background. This enables support for images with alpha layers and fixes issue #1254.