This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
diagnostics: convert columns to bytes #1579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name-snrl
force-pushed
the
fix-diagnostics-columns
branch
from
cf04dfd to
28aec7d
Compare
|
Seems like a reasonable change, but the failing tests indicate that this might need more attention. Can you check them out? |
I'm sorry, I don't know when I'll have time for this. Also, I think the code needs to be refined. In general, my code is a highly stripped-down function, which I mentioned in the issue, but I may have cut out important things. |
name-snrl
force-pushed
the
fix-diagnostics-columns
branch
2 times, most recently
from
fc97e7d to
e32135c
Compare
|
@jose-elias-alvarez This is finally solution. I'm not familiar with the tests, could you please resolve this part? |
name-snrl
force-pushed
the
fix-diagnostics-columns
branch
from
e32135c to
b043e35
Compare
name-snrl
force-pushed
the
fix-diagnostics-columns
branch
from
b043e35 to
9ccbd1d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation #1577.
Works in my case, but it was done in the morning hastily, but I think it is a good start