-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module #1249
Open
Thrameos
wants to merge
43
commits into
jpype-project:master
Choose a base branch
from
Thrameos:module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Module #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raise ValueError("Unable to find ascii temp directory.") | ||
shutil.copyfile(support_lib, path) | ||
support_lib = path | ||
tmp = path |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
This assignment to 'tmp' is unnecessary as it is before this value is used.
redefined
Error loading related location
Loading @@ -67,6 +67,15 @@ | |||
raise unittest.SkipTest("numpy required") | |||
return f | |||
|
|||
def requireAscii(func): | |||
def f(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note test
Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder for module support. This is built off the noagent PR, so it will need to be rebased once that is included.
Key points:
Needs:
Review will defer until after the 1.5.1 mess is dealt with.