Template 04 Controls ESNext #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge jess into new branch
merge jess into branch
…ordPress#22744) Co-authored-by: Andrés <[email protected]> (+1 squashed commit)
`npm run build` will generate an `index.js` file at `builds/index.js`, and not a blocks.js.
* Scripts: Add support for postcss.config.js * Support all postcss config formats * Rename hasPostCssConfig() to hasPostCSSConfig()
The following PRs were fine in isolation, but when merged resulted in the introduction of an undefined `Source` type in the `env` package: WordPress#22256 WordPress#20522 Rename `Source` introduced in WordPress#22256 to `WPSource` according to changes in WordPress#20522.
* Remove Keyboard.dismiss() when deleting block * Move selection to end of link after insertion. (WordPress#22652) Make sure the selection is refreshed after changed. * Only show pullquote block on iOS. * Allow pullquote block to show on Android Dev builds * Change indentifier type in Button, correct concatenation in merge function (WordPress#22708) * [RNMobile] Fix footer appender in buttons block (WordPress#22711) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes (WordPress#22716) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * [RNMobile] Correct color selection in color settings (WordPress#22736) * [RNMobile] Fix: Add default value to format when start and end are undefined (WordPress#22741) * add default vale to format when start and end are undefined * revert lint changes * Fix lint issue Co-authored-by: lukewalczak <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]> Co-authored-by: Drapich Piotr <[email protected]>
As written this is a syntax error; the PR fixes it.
Co-authored-by: Marcus Kazmierczak <[email protected]> Co-authored-by: jasmussen <[email protected]>
) Co-authored-by: Alex Lende <[email protected]>
…ordPress#22695) * REST API: Update default value for parent in the block type schema * Align changes with the WordPress core patch * Fix missed spelling change for textdomain * Fix copy&paste in block types REST API endpoint * Update lib/class-wp-rest-block-types-controller.php Co-authored-by: Jonny Harris <[email protected]> * Fix issues raised by PHP linter Co-authored-by: Jonny Harris <[email protected]>
* Type package * Add node eslint config * Add changelog * Update util path in build scripts
* Squash * Use isResolving selector to determine whether or not the blocks should be recomputed * Pass the previous menuItemsRef.current to menuItemsToLinkBlocks
* Blocks: Update default block categories * Block API: Add wp.blocks.getCategory singular function * Blocks: Normalize block category during registration * Block Library: Reorganize blocks to new categories * E2E Tests: Update block directory test to use updated category * Compat: Reconcile against core-updated categories Anticipate that core will update to use new categories. Avoid duplicate categories, since legacy categories will not exist to be replaced. * Compat: Add Trac ticket for block category updates
…splay author (WordPress#16169) * Added ability to filter latest posts by author * Updates to catch up to changes in Gutenberg * Fixes error of: Notice: Undefined index: items in /wp-includes/rest-api.php on line "1245" * Removed unused variables and fixed linting issues * Removed Whitespace from index.php * adding new line to index.php * applied changes suggested by @draganescu to LatestPosts block * linting edit * Updated from users to author on LatestPosts block * Added display author option * Updated edit.js on LatestPosts to match front end on author label * Attempt to fix tests on LatestPosts * Update e2e tests for LatestPostsa * Fix for PHP Unit tests * Updated rendering of author name on editor view * Changed 'posted by' to 'by' on the byline * Fixed linting issue in index.php for LatestPost * Fixed formatting issues in index.php for LatestPosts * fix to undefined author_info Co-authored-by: Paul Stonier <[email protected]>
* First stab at encapsulation of useNavigationBlocks * Flicker issue solved again * Encapsulated parts of the logic from useNavigationBlocks * Formatting * Decouple fetching the data, transforming, saving, and creating draft posts * Move blocks argument to useSaveNavigationBlocks hook * Separate fetching menu items from creating navigation blocks * Move PromiseQueue to use-create-missing-menu-items as it is only used there * construct query inline instead of having useMenuItemsQuery * Simplify the refactor (thank you Andrei!) * Extract PromiseQueue into a separate file * Move eventuallySaveItems to useMenuItems * Update packages/edit-navigation/src/components/menu-editor/use-create-missing-menu-items.js Co-authored-by: andrei draganescu <[email protected]> * Update packages/edit-navigation/src/components/menu-editor/use-create-missing-menu-items.js Co-authored-by: andrei draganescu <[email protected]> * Show the notice after receiveEntityRecords * Fix spacing issue * Remove rogue async * rename linkBlocks to blocks Co-authored-by: andrei draganescu <[email protected]>
…creen (WordPress#22792) * Disable the navigator toolbar button on the experimental navigation screen * Use __experimentalNavigationScreen
…2828) * Use Panel for navigation structure on small screens only * Adjust CSS
…#22905) * Block Editor: Remove ifBlockEditSelected internal higher-order component * Block Editor: Pass children to inspector fills
* Use React hooks for TabPanel component * Use hook for instanceId * Fix instanceId and use template literals Co-authored-by: Patrick Villanueva <[email protected]>
…dPress#22876) * Template Part: Don't set post ID until the first edit. * Entities Saved States: Call the save callback before actually saving. * Edit Site: Set new templates' status and title right before saving instead of on load. * Template Part: Don't set status on mount. * Template Part: Update tests.
* Add alignment control to the site title block edit function. * Add support for setting site title tag, and applying text alignment in the editor and front end. * Fix up classname output, and add a default site title classname. * Fix PHP linting issues.
…t more useful (WordPress#22577) * Try: removing the multi-block type check to make __experimentalConvert more useful * Remove unneeded isBlockSelectionOfSameType tests * Add additional test cases for __experimentalConvert to catch * and block matches * fix whitespace for linter
* Adding actions to unsupported block sheet * Send unsupported fallback message to native * Adding bridge listener to replace a single block with the given blocks in html * Change unsupported blocks copy and button color * Sending block title on unsupported block fallback message * Fix dark-mode color of action button * Add style to Dismiss button on Unsupported block bottom sheet * Revert "Mobile Bundle" * Put unsupported block editor on dev builds Co-authored-by: Marko Savic <[email protected]> Co-authored-by: Paul Von Schrottky <[email protected]>
* Update triage to include release instructions After chatting with @aduth about release specific triage processes, I wanted to pull together insights he shared around how to approach adding milestones, flagging bugs for the team, etc. Adding this in as an update to these instructions. * Update docs/contributors/triage.md Co-authored-by: Andrew Duthie <[email protected]> Co-authored-by: Marcus Kazmierczak <[email protected]> Co-authored-by: Andrew Duthie <[email protected]>
…and (WordPress#22661) * Use shorter friendlier version of command * Update packages/e2e-tests/fixtures/blocks/README.md Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Marcus Kazmierczak <[email protected]> Co-authored-by: Greg Ziółkowski <[email protected]>
…current esnext template, rename template controls-esnext accordingly;
intelijens
assigned rbest, brezocordero and fabiankaegy and unassigned brezocordero and fabiankaegy
|
Size Change: +16.4 kB (1%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
recreated new branch with appropriately titled branch name, following other examples from JSA Team Leads. Cleaner approach and commits, also pulled directly from JSA/gutenberg vs having multiple origins, causing WP/gutenberg master to inappropriately pulled and merged without TL consent. New branch: https://github.com/js-advancers/gutenberg/commits/add/controls-template-esnext and PR: #12 |
|
declined PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new template for Gutenberg Example - 04 - Controls ESNext to match https://github.com/WordPress/gutenberg-examples/tree/master/04-controls-esnext example
Description
How has this been tested?
Screenshots
Types of changes
Checklist: