Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rails < 7.0, Ruby < 3.1, test against 7.1, 7.2, test against Ruby 3.3, fix ruby-head #152

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Sep 15, 2024

Close #147

@tagliala tagliala changed the title Chore/test ruby 33 rails 72 Drop Rails 5.x, test against 7.1, 7.2, test against Ruby 3.3 Sep 15, 2024
@tagliala tagliala force-pushed the chore/test-ruby-33-rails-72 branch 2 times, most recently from 133f161 to a8581b9 Compare September 15, 2024 15:33
@tagliala tagliala changed the title Drop Rails 5.x, test against 7.1, 7.2, test against Ruby 3.3 Drop Rails 5.x, test against 7.1, 7.2, test against Ruby 3.3, fix ruby-head Sep 15, 2024
@tagliala tagliala force-pushed the chore/test-ruby-33-rails-72 branch from a8581b9 to 87ef18c Compare September 15, 2024 15:34
@tagliala tagliala marked this pull request as ready for review September 15, 2024 15:35
@tagliala tagliala force-pushed the chore/test-ruby-33-rails-72 branch from 87ef18c to 06dc80e Compare October 2, 2024 07:26
@tagliala tagliala changed the title Drop Rails 5.x, test against 7.1, 7.2, test against Ruby 3.3, fix ruby-head Drop Rails < 7.0, Ruby < 3.1, test against 7.1, 7.2, test against Ruby 3.3, fix ruby-head Oct 2, 2024
Also:
- Update checkout action
- Load correct sqlite3 version
- Set minimum required ruby version (according to Rails 6.0)
Replace OpenStruct with Struct to allow spec passing against ruby-head
without requiring openstruct in development dependencies
- Drop Ruby < 3.1.0
- Drop Rails < 7.0.0
@tagliala tagliala force-pushed the chore/test-ruby-33-rails-72 branch from 5e13b1b to 47447e2 Compare October 2, 2024 19:12
@tagliala tagliala force-pushed the chore/test-ruby-33-rails-72 branch from 47447e2 to 87246b7 Compare October 2, 2024 19:12
@remear
Copy link
Member

remear commented Oct 2, 2024

Thanks for this!

@remear remear merged commit 2e1b5b1 into jsonapi-rb:master Oct 2, 2024
15 checks passed
@tagliala tagliala deleted the chore/test-ruby-33-rails-72 branch October 3, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Rails 5 support
2 participants