Pin jupyterlab for now (#118)

* Pin jupyterlab for now * debug * debug * dbg * dbg * dbg * dbg * dbg * dbg * dbg * dbg * give up
jtpio · Feb 21, 2024 · 56b7a40 · 56b7a40
1 parent becf189
commit 56b7a40
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,7 +20,7 @@ jobs:
         uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
 
       - name: Install dependencies
-        run: python -m pip install -U "jupyterlab>=4.0.0,<5"
+        run: python -m pip install -U "jupyterlab>=4.0,<4.1"
 
       - name: Lint the extension
         run: |
@@ -74,7 +74,7 @@ jobs:
           sudo rm -rf $(which node)
           sudo rm -rf $(which node)
 
-          pip install "jupyterlab>=4.0.0,<5" p5_notebook*.whl
+          pip install "jupyterlab>=4.0,<4.1" p5_notebook*.whl
 
 
           jupyter labextension list

diff --git a/deploy.sh b/deploy.sh
@@ -5,8 +5,12 @@ set -xeu
 
 # install pixi
 export PIXI_VERSION=v0.9.1 && curl -fsSL https://pixi.sh/install.sh | bash
-source ~/.bashrc
 
-pixi install
-pixi run build_lite
-pixi run copy_favicon
+# This started to fail as of February 21st 2024
+# See commit log in https://github.com/jtpio/p5-notebook/pull/118
+# source ~/.bashrc
+
+# So explicitly pointing to the pixi binary instead
+~/.pixi/bin/pixi install
+~/.pixi/bin/pixi run build_lite
+~/.pixi/bin/pixi run copy_favicon