Refactor some code #3655
Merged
Refactor some code #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, forgot to test it. |
junegunn
reviewed
Mar 4, 2024
src/server.go
Outdated
Comment on lines
239
to
247
| val, err := strconv.Atoi(parts[1]) | ||
| if err != nil { | ||
| continue | ||
| } | ||
| switch parts[0] { | ||
| case "limit": | ||
| val, err := strconv.Atoi(parts[1]) | ||
| if err == nil { | ||
| params.limit = val | ||
| } | ||
| params.limit = val | ||
| case "offset": | ||
| val, err := strconv.Atoi(parts[1]) | ||
| if err == nil { | ||
| params.offset = val | ||
| } | ||
| params.offset = val |
There was a problem hiding this comment.
I'm not sure about this. We don't want to call Atoi for other unsupported parameters.
This is what I'm suggesting.
switch parts[0] {
case "limit", "offset":
if val, err := strconv.Atoi(parts[1]); err == nil {
if parts[0] == "limit" {
params.limit = val
} else {
params.offset = val
}
}
}There was a problem hiding this comment.
This looks much better! I'll update it as you suggested. Thank you for your feedback!
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.