Make eslint understand modern .js with babel's parser #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/make-eslint
branch
from
0a6f1f8 to
c9e711b
Compare
consideRatio
added
maintenance
|
Thanks for sorting this out, @consideRatio |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 9, 2023
jupyterhub/binderhub#1768 Merge pull request #1768 from consideRatio/pr/make-eslint
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we can use prettier in pre-commit without getting errors stemming from the formatting changes. Previously we did because the eslint's .js parser was not modern enough to support the formatting changes.
By switching to use the
@babel/eslint-parserwe are fine for now at least, and I think in the future as well, because we end up using a parser that is provided by babel, which is also what we use to transform the .js into something else.