Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use self.log.warning instead of warnings.warn #1384

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Use self.log.warning instead of warnings.warn #1384

merged 3 commits into from
Jan 3, 2025

Conversation

yuvipanda
Copy link
Collaborator

warnings.warn sidesteps all the json logging bits we do, and repo2docker will produce non-json output that binderhub then struggles to consume.

@yuvipanda yuvipanda requested review from minrk and manics and removed request for minrk December 8, 2024 08:23
@yuvipanda
Copy link
Collaborator Author

failed: Error during build: Expecting value: line 1 column 1 (char 0)unknown: Exception ignored in: <function Application.__del__ at 0x105855300> is what I get without this from binderhub

@yuvipanda
Copy link
Collaborator Author

Hmm, so the errors aren't actually coming from this - they're coming from somewhere else. Debugging...

@yuvipanda
Use self.log.warning instead of warnings.warn
025277d 
warnings.warn sidesteps all the json logging bits we do,
and repo2docker will produce non-json output that binderhub
then struggles to consume.
@yuvipanda
Re-add warnings usage in one place
29ee4c3 
This actually seems appropriate
@yuvipanda
Copy link
Collaborator Author

I think this should fix the tests!

@manics
Copy link
Member

manics commented Dec 21, 2024

Can you also remove the import warnings? I'm surprised this isn't picked up by one of the linters.

@yuvipanda
Copy link
Collaborator Author

@manics yea i noticed yesterday we don't actually have a flake8 linter here and that means there's actually a ton of unused imports! As well as things like #1392

@manics manics merged commit dd097a2 into jupyterhub:main Jan 3, 2025
19 checks passed
@jupyterhub-bot jupyterhub-bot mentioned this pull request Jan 4, 2025
Merged
@manics manics added the maintenance Under the hood fixes and improvements label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

Assignees
No one assigned
Labels
maintenance Under the hood fixes and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @manics