Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version back to 5.0.0 #588

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

martincostello
Copy link
Member

We dropped several TFMs since the last release, so we still need to bump the major version even with the changes in #416.

- <TargetFrameworks>net461;netstandard2.0;netstandard2.1;netcoreapp2.1;net5.0</TargetFrameworks>
+ <TargetFrameworks>net462;netstandard2.0;net6.0</TargetFrameworks>

Alternatively, if we still want to release as 4.3.0 then do a different PR to put them back.

Thoughts?

We dropped several TFMs since the last release, so we still need to bump the major version.
Use `MSBUILDTERMINALLOGGER=auto` to get nicer output from the .NET SDK.
@martincostello martincostello added this to the v4.3.0 milestone Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d083ff) 83.18% compared to head (d96b08a) 83.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   83.18%   83.77%   +0.59%     
==========================================
  Files          28       28              
  Lines         666      672       +6     
  Branches      150      151       +1     
==========================================
+ Hits          554      563       +9     
+ Misses         70       67       -3     
  Partials       42       42              
Flag Coverage Δ
linux 83.18% <ø> (+0.60%) ⬆️
macos 83.03% <ø> (+0.60%) ⬆️
windows 82.73% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about it and it makes sense to bump the version

@martincostello martincostello marked this pull request as ready for review December 5, 2023 11:50
@martincostello martincostello requested a review from a team as a code owner December 5, 2023 11:50
@martincostello martincostello merged commit 8f40207 into justeattakeaway:main Dec 5, 2023
13 checks passed
@martincostello martincostello deleted the bump-version branch December 5, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants