closing a port twice crashes node

[agoode]

> input.closePort(0)
undefined
> input.closePort(0)
node: ../src/node_object_wrap.h:104: virtual void node::ObjectWrap::Unref(): Assertion `!handle_.IsWeak()' failed.
Aborted

node version v0.10.9

[hhromic]

This issue seems to be fixed now, shouldn't be closed? :)

[drewish]

Give it a try. I think it still crashes.

[keinstein]

For me it crashes. Playing around with node-midi I found out that it doesn't try to set the client name. So you could set the client name to the same name as the port name and check the first part of the returned name. Setting the client name should be supported by node-midi anyway. RtMidi already supports that.

[drewish]

@keinstein you can set the name but it doesn't always return it, totally depends on the library you're linked against. But I see you've found thestk/rtmidi#6 too ;)

[keinstein]

As far as I know, RtMidi returns either the port name or the client name + some stuff. So, if you set port and client to the same name, you could be shure that this name is a part of the port description that is returned by RtMidi.

Btw. Switching to port names for ALSA wouldn't solve the issue as some drivers name their ports just “port 1” etc.

[drewish]

Feel free to give it a go, I'm happy to review any patches. Try testing it on a couple of platforms though.