[FieldinTypeAlias] Change API to accept multiple fields #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jxxcarlson I started with FieldInTypeAlias because the ClauseInCase module is a little more complex (we still need to think what should be the type of the list with the new clause, I think). Also, I only changed the API to accept a list instead of a single string, but didn't address the other suggestions, like changing "init" to "config". |
|
Very nice implementation of the new API! One thing we may want to consider later is the option of overwriting fields that exist in both the target type and in the list of fields to be added. Lets discuss at some point — this may not be a good idea. |
|
pulled and merged locally. Will push momentariy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34.