Honour multi interface scenario on the pod container #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @JanScheurich, @phoracek |
|
Hi @pperiyasamy Thank you for the PRs! It seems to require to modify https://github.com/k8snetworkplumbingwg/multi-net-spec , so how about to discuss about it in NPWG meeting? |
@s1061123 sure, thanks. let's discuss this item in the next NPWG meeting. |
|
@s1061123 Hi, @JanScheurich and myself would propose this with document and a small demo, but not in today's meeting, would present it in next NPWG meeting (20/05). |
This patch is to update nw status with all relevant information when pod container has secondary interface with its vlan sub interfaces. Signed-off-by: Periyasamy Palanisamy <[email protected]>
Signed-off-by: Periyasamy Palanisamy <[email protected]>
pperiyasamy
force-pushed
the
vlan-sub-interface
branch
from
02be362 to
6aaf958
Compare
This commit doesn't also include interfaces into nw status which doesn't have if name, device id and ip addresses Signed-off-by: Periyasamy Palanisamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make changes into CreateNetworkStatus API so that it can consider mutiple container interfaces while building network status. There are cases where delegate CNI would create more than one interface on CMD ADD call into the pod container, then CNI would return more than one interface in the result object.
The multus cni would have to build network status annotation with all interfaces including its IP details. Will raise a PR in multus cni to adapt with this API change. But of course this API change have to reviewed and check if it's covering every aspects and backward compatibility.
Here is a multi interface use case described in this ovs-cni PR