Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: containerize build - part 2 #188

Merged
merged 13 commits into from
Dec 18, 2023
Merged

feat: containerize build - part 2 #188

merged 13 commits into from
Dec 18, 2023

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Dec 12, 2023

This PR takes logic out of git action and places it into a python script and K8s jobs that can handle concurrent docker image builds.

The Python script does the following:

  1. Checks the modified files
  2. Creates custom docker job files for each build
  3. Spawns the docker job for each build
  4. Reports the success of the job back to the git action (timeout after 3600 sec)

Note: Since K8s jobs are isolated/independent, program can handle concurrent git actions running (e.g. two jobs building the same image)

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0f963e) 68.66% compared to head (bba055b) 68.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files          14       14           
  Lines        1366     1366           
=======================================
  Hits          938      938           
  Misses        391      391           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 marked this pull request as ready for review December 14, 2023 04:52
@Fei-Guo Fei-Guo merged commit dc09bf1 into main Dec 18, 2023
9 checks passed
@Fei-Guo Fei-Guo deleted the Ishaan/containerize-build branch December 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants