Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor to implement model plugin - part 4 #190

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Dec 14, 2023

This PR largely refactor the workspace spec validation code.

  • Use information from registered model (remove PresetRequirementsMap) to do validation.
  • The UTs for validation need to be rewritten. Comment all for now.
  • Move interface definition to a separate directory to avoid cyclic import.
  • Adjust to add
        GPUCountRequirement       string
	TotalGPUMemoryRequirement string
	PerGPUMemoryRequirement   string

to inference parameters.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (e0f3a35) 77.89% compared to head (490c6d6) 62.44%.

Files Patch % Lines
api/v1alpha1/workspace_validation.go 0.00% 20 Missing ⚠️
pkg/controllers/workspace_controller.go 20.00% 4 Missing ⚠️
api/v1alpha1/sku_config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #190       +/-   ##
===========================================
- Coverage   77.89%   62.44%   -15.46%     
===========================================
  Files           9       14        +5     
  Lines        1095     1366      +271     
===========================================
  Hits          853      853               
- Misses        208      479      +271     
  Partials       34       34               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit c1151fd into main Dec 14, 2023
9 of 11 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch December 14, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants