Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: remove machine and aws/karpenter-core dependency from kaito #806

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rambohe-ch
Copy link
Collaborator

@rambohe-ch rambohe-ch commented Jan 7, 2025

Reason for Change:

  1. remove machine resource
  2. remove aws/karpenter-core dependency
  3. upgrade gpu-provisioner version to v0.2.2(support nodeclaim api)

Requirements

  • modified unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

1. remove machine resource
2. remove aws/karpenter-core dependency
3. upgrade gpu-provisioner version to v0.2.2(support nodeclaim api)

Signed-off-by: rambohe-ch <[email protected]>
@rambohe-ch rambohe-ch changed the title [WIP] feat: remove machine and aws/karpenter-core dependency from kaito feat: remove machine and aws/karpenter-core dependency from kaito Jan 9, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.74074% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/ragengine/controllers/ragengine_controller.go 37.50% 9 Missing and 1 partial ⚠️
pkg/workspace/controllers/workspace_controller.go 41.17% 9 Missing and 1 partial ⚠️
...kg/ragengine/controllers/ragengine_gc_finalizer.go 0.00% 9 Missing ⚠️
pkg/utils/common.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
pkg/featuregates/featuregates.go 100.00% <ø> (ø)
pkg/utils/test/mockClient.go 77.67% <ø> (-1.32%) ⬇️
pkg/utils/test/testUtils.go 100.00% <ø> (ø)
...kg/workspace/controllers/workspace_gc_finalizer.go 100.00% <100.00%> (ø)
pkg/utils/common.go 12.26% <0.00%> (+0.07%) ⬆️
...kg/ragengine/controllers/ragengine_gc_finalizer.go 0.00% <0.00%> (ø)
pkg/ragengine/controllers/ragengine_controller.go 41.05% <37.50%> (+3.57%) ⬆️
pkg/workspace/controllers/workspace_controller.go 40.68% <41.17%> (+1.75%) ⬆️

@rambohe-ch rambohe-ch changed the title feat: remove machine and aws/karpenter-core dependency from kaito [WIP] feat: remove machine and aws/karpenter-core dependency from kaito Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants