Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize some keystrokes #579

Closed

Conversation

shreeve
Copy link
Contributor

@shreeve shreeve commented May 15, 2023

Changes reset from Ctrl+D (usually for exiting a CLI program) -> Ctrl+R (for "reset"). Also, makes the output after a reset a little more clear.

Changes reset from Ctrl+D (usually for exiting a CLI program) -> Ctrl+R (for "reset"). Also, makes the output after a reset a little more clear.
@shreeve
Copy link
Contributor Author

shreeve commented May 15, 2023

This PR goes with one for kaluma-cli at kaluma-project/kaluma-cli#36

@communix
Copy link
Collaborator

@shreeve The REPL command is compatible to the Node.js. So I want to keep the previous key.

@communix communix closed this May 20, 2023
@shreeve
Copy link
Contributor Author

shreeve commented May 20, 2023

Monosnap node 2023-05-20 17-20-46

Ctrl+D exits the node REPL, no?

@shreeve
Copy link
Contributor Author

shreeve commented May 20, 2023

$ node -v
v20.1.0

@communix
Copy link
Collaborator

@shreeve Yes, it's exit the node in Node.js.
For the reset, Kaluma provide .reset command and it's recommended for soft reset. The reason we add CTRL+D is it's like a exit in Kaluma.
Node.js runs on top of the shell and it goes to the shell when user want to exit from Node.js. Different from Node, Kaluma does not have any shell to go back. So when user want to exit it, Kaluma have to go back to Kaluma REPL. So it's the same as reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants