Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify interpreter webhook service discovery usage #5969

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Dec 24, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

In order to guide users to better use the resource interpreter webhook, the configuration description of clientConfig is added, and the directory description is also added.

Which issue(s) this PR fixes:
Fixes #5958

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 24, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 24, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-introduction-intrepreter-webhook branch from bdf5211 to 77a94ad Compare December 24, 2024 02:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.24%. Comparing base (8d89d77) to head (463154b).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5969      +/-   ##
==========================================
+ Coverage   48.17%   48.24%   +0.07%     
==========================================
  Files         664      664              
  Lines       54799    54749      -50     
==========================================
+ Hits        26399    26415      +16     
+ Misses      26684    26620      -64     
+ Partials     1716     1714       -2     
Flag Coverage Δ
unittests 48.24% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @lxtywypc

Copy link
Contributor

@lxtywypc lxtywypc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another point I'm not sure, if we could deploy the load balancer through karmada-apiserver?

Others LGTM.

examples/customresourceinterpreter/README.md Outdated Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member Author

And another point I'm not sure, if we could deploy the load balancer through karmada-apiserver?

This test has not been performed. I understand that the cluster IP address in the service of karmada-apiserver should be fake. NodePort or LoadBalancer depend on this cluster IP address and cannot be accessed.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-introduction-intrepreter-webhook branch from 77a94ad to 463154b Compare December 24, 2024 10:57
@RainbowMango
Copy link
Member

/retitle Clarify interpreter webhook service discovery usage

@karmada-bot karmada-bot changed the title Add the introduction of configuring clientConfig to the resource intrepreter webhook Clarify interpreter webhook service discovery usage Dec 24, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@karmada-bot karmada-bot merged commit 7112723 into karmada-io:master Dec 24, 2024
21 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-introduction-intrepreter-webhook branch December 27, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access karmada-interpreter-webhook by configuring Service in ResourceInterpreterWebhookConfiguration
5 participants