-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify interpreter webhook service discovery usage #5969
Clarify interpreter webhook service discovery usage #5969
Conversation
bdf5211
to
77a94ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5969 +/- ##
==========================================
+ Coverage 48.17% 48.24% +0.07%
==========================================
Files 664 664
Lines 54799 54749 -50
==========================================
+ Hits 26399 26415 +16
+ Misses 26684 26620 -64
+ Partials 1716 1714 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another point I'm not sure, if we could deploy the load balancer through karmada-apiserver?
Others LGTM.
This test has not been performed. I understand that the cluster IP address in the service of karmada-apiserver should be fake. NodePort or LoadBalancer depend on this cluster IP address and cannot be accessed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
…epreter webhook Signed-off-by: changzhen <[email protected]>
77a94ad
to
463154b
Compare
/retitle Clarify interpreter webhook service discovery usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
In order to guide users to better use the resource interpreter webhook, the configuration description of clientConfig is added, and the directory description is also added.
Which issue(s) this PR fixes:
Fixes #5958
Special notes for your reviewer:
Does this PR introduce a user-facing change?: