Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5989: fix rebalancer auto deleted failed #5995

Conversation

deefreak
Copy link

@deefreak deefreak commented Dec 30, 2024

Cherry pick of #5989 on release-1.12.
#5989: fix rebalancer auto deleted failed
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the bug of WorkloadRebalancer doesn't get deleted after TTL.

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2024
@RainbowMango
Copy link
Member

/retest
The failing test is unrelated:

FAIL pkg/search.TestDeleteClusterEventHandler/AddAllEventHandlers_TriggerDeleteClusterEvent_DeletedClusterAddedToWorkQueue (-1.00s)
  FAIL pkg/search.TestDeleteClusterEventHandler (-1.00s)
make: *** [Makefile:122: test] Error 1

=== Failed
=== FAIL: pkg/search  (0.00s)
panic: test timed out after 10m0s
running tests:
	TestDeleteClusterEventHandler (10m0s)
	TestDeleteClusterEventHandler/AddAllEventHandlers_TriggerDeleteClusterEvent_DeletedClusterAddedToWorkQueue (10m0s)

goroutine 195 [running]:
testing.(*M).startAlarm.func1()
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:2366 +0x265
created by time.goFunc
	/opt/hostedtoolcache/go/1.22.9/x64/src/time/sleep.go:177 +0x45

goroutine 1 [chan receive, 10 minutes]:
testing.(*T).Run(0xc0002e6d00, {0x3e6aef7, 0x1d}, 0x3f79198)
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:1750 +0x851
testing.runTests.func1(0xc0002e6d00)
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:2161 +0x86
testing.tRunner(0xc0002e6d00, 0xc00006db00)
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:1689 +0x21f
testing.runTests(0xc00034e528, {0x5c86180, 0x8, 0x8}, {0xc00006dba8?, 0xc00006dbf0?, 0x5ca8fe0?})
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:2159 +0x8bf
testing.(*M).Run(0xc000701900)
	/opt/hostedtoolcache/go/1.22.9/x64/src/testing/testing.go:2027 +0xf18
main.main()

@RainbowMango
Copy link
Member

cc @XiShanYongYe-Chang
Any update regarding the failing test?
Is there an issue tracking this?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.52%. Comparing base (42fafd7) to head (bd911d8).

Files with missing lines Patch % Lines
...orkloadrebalancer/workloadrebalancer_controller.go 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #5995      +/-   ##
================================================
- Coverage         46.52%   46.52%   -0.01%     
================================================
  Files               664      664              
  Lines             54787    54785       -2     
================================================
- Hits              25492    25487       -5     
- Misses            27669    27671       +2     
- Partials           1626     1627       +1     
Flag Coverage Δ
unittests 46.52% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Any update regarding the failing test?

It was recently fixed with #5936, and the cause of the error was not fully determined. After the repair, the probability of occasional occurrence has decreased, but it is still not avoided.

Is there an issue tracking this?

The issue needs to be re-opened to track the issue: #5926

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@karmada-bot karmada-bot merged commit 3e154f7 into karmada-io:release-1.12 Dec 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants