feat : add cluster registration in pull mode to installation workflow #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
do-not-merge/contains-merge-commits
Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
…eduler Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: RainbowMango <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Anuj Agrawal <[email protected]> Signed-off-by: Akash <[email protected]>
In this commit, we introduce unit tests for both the `MutatingAdmission`
and `ValidatingAdmission` webhooks specifically for the `FederatedHPA`
resource.
The tests include:
- Validation webhook tests:
- Verifies that admission is denied with an appropriate error message
when decoding the request object fails.
- Ensures admission is denied when the `FederatedHPA` spec contains
invalid values, such as a `minReplicas` set to zero, and the correct
error message is returned.
- Confirms that a valid `FederatedHPA` object is allowed through without
errors.
- Mutation webhook tests:
- Verifies that admission is denied when decoding the request object
fails, returning the appropriate error message.
- Ensures that the `FederatedHPA` object is correctly mutated when
provided with default values, including scale policies and CPU
utilization.
- Confirms that no patches are applied when the `FederatedHPA` object is
handled correctly and that admission is allowed for valid
`FederatedHPA` objects.
Signed-off-by: Mohamed Awnallah <[email protected]>
Signed-off-by: Akash <[email protected]>
Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: sophie <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: RainbowMango <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Anuj Agrawal <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: chang.qiangqiang <[email protected]> Signed-off-by: Akash <[email protected]>
In this commit, we unit test the init scheme functionality of the operator by checking that both k8s core scheme and operator v1alpha1 scheme are added. Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Anuj Agrawal <[email protected]> Signed-off-by: Akash <[email protected]>
In this commit, we introduce unit tests for mutating and validating webhook configurations to make sure they are working as expected. Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: RainbowMango <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: wulemao <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: wangxiaofei67 <[email protected]> fix: add signoff Signed-off-by: wangxiaofei67 <[email protected]> fix: optimize prompt messages in the logs Signed-off-by: Akash <[email protected]>
Signed-off-by: Anuj Agrawal <[email protected]> Changed the resource to clusterrole Signed-off-by: Anuj Agrawal <[email protected]> Added tests for workloadrebalancer controller Signed-off-by: Anuj Agrawal <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]> Signed-off-by: Akash <[email protected]>
…allation Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Co-authored-by: yelshall <[email protected]> Signed-off-by: Julian Lawrence <[email protected]> Signed-off-by: Akash <[email protected]>
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@v3.6.0...v3.7.0) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> add Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> add file change Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix doc Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix comment Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> fix Signed-off-by: tiansuo114 <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Amir Alavi <[email protected]> Signed-off-by: Akash <[email protected]>
In this commit, we unit test apiclient on creating restconfig. Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
…eted in the dependencies distribution scenario Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: LavredisG <[email protected]> Signed-off-by: Akash <[email protected]>
…ooks[*].clientConfig.service.port is nil Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Mohamed Awnallah <[email protected]> Signed-off-by: Akash <[email protected]>
…epreter webhook Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Joe Nathan Abellard <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Monokaix <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: chaosi-zju <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Anuj Agrawal <[email protected]> Added tests for pkg/util/helper/work.go Signed-off-by: Anuj Agrawal <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: changzhen <[email protected]> Signed-off-by: Akash <[email protected]>
Signed-off-by: Akash <[email protected]>
SkySingh04
force-pushed
the
karmadactlCiCLI
branch
from
b622b3c to
38ed053
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
karmada-bot
added
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
do-not-merge/contains-merge-commits
|
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
karmada-bot
added
size/XS
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6005 +/- ##
=======================================
Coverage 48.37% 48.38%
=======================================
Files 665 665
Lines 54795 54795
=======================================
+ Hits 26507 26510 +3
+ Misses 26569 26567 -2
+ Partials 1719 1718 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5916
Special notes for your reviewer:
Does this PR introduce a user-facing change?: