Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceBinding scheduling suspension helper function #6019

Merged

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Jan 6, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add ResourceBinding scheduling suspension helper function to simplify code.

Which issue(s) this PR fixes:
Part of #5977

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 6, 2025
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 6, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.35%. Comparing base (0d938d0) to head (2f180f2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6019      +/-   ##
==========================================
- Coverage   48.38%   48.35%   -0.03%     
==========================================
  Files         665      665              
  Lines       54836    54831       -5     
==========================================
- Hits        26530    26512      -18     
- Misses      26589    26600      +11     
- Partials     1717     1719       +2     
Flag Coverage Δ
unittests 48.35% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member Author

@Monokaix Can you help to take a look?

@Monokaix
Copy link
Contributor

Monokaix commented Jan 7, 2025

It's a good catch: )

@RainbowMango RainbowMango added this to the v1.13 milestone Jan 7, 2025
@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 7, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 56194cb into karmada-io:master Jan 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants