Skip to content

Commit

Permalink
Temporarily remove PulseInternal
Browse files Browse the repository at this point in the history
  • Loading branch information
kean committed Oct 18, 2021
1 parent 9123fc3 commit 1f9c031
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 40 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Pulse 0.x

## Pulse 0.19.1

*18 Oct, 2021*

- Temporarily remove `PulseInternal`

## Pulse 0.19.0

*17 Oct, 2021*
Expand Down
3 changes: 1 addition & 2 deletions Pulse/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ let package = Package(
targets: [
.target(name: "PulseUI", dependencies: ["PulseCore"]),
.target(name: "Pulse", dependencies: [.product(name: "Logging", package: "swift-log"), "PulseCore"]),
.target(name: "PulseCore", dependencies: ["PulseInternal"]),
.target(name: "PulseInternal"),
.target(name: "PulseCore"),
.testTarget(name: "PulseTests", dependencies: ["Pulse"], resources: [.process("Resources")])
]
)
9 changes: 2 additions & 7 deletions Pulse/Sources/PulseCore/LoggerStore.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import Foundation
import CoreData
import PulseInternal

/// `LoggerStore` persistently stores all of the logged messages, network
/// requests, and blobs. Use `.default` store to log messages.
Expand Down Expand Up @@ -382,9 +381,7 @@ extension LoggerStore {
backgroundContext.perform { [weak self] in
guard let self = self else { return }
if self.isSaveScheduled {
try? _ExceptionCatcher.catchException {
try? self.backgroundContext.save()
}
try? self.backgroundContext.save()
self.isSaveScheduled = false
}
completion?()
Expand Down Expand Up @@ -420,9 +417,7 @@ extension LoggerStore {
private func performChangesOnMain(_ closure: (NSManagedObjectContext) -> Void) {
precondition(Thread.isMainThread)
closure(container.viewContext)
try? _ExceptionCatcher.catchException {
try? container.viewContext.save()
}
try? container.viewContext.save()
}

private func perform(_ changes: @escaping () -> Void) {
Expand Down
20 changes: 0 additions & 20 deletions Pulse/Sources/PulseInternal/ExceptionCatcher.m

This file was deleted.

11 changes: 0 additions & 11 deletions Pulse/Sources/PulseInternal/include/ExceptionCatcher.h

This file was deleted.

0 comments on commit 1f9c031

Please sign in to comment.