Fix arithmetic overflow

kean · Nov 5, 2023 · fcc7253 · fcc7253
1 parent 263602c
commit fcc7253
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Pulse 4.x
 
+## Pulse 4.0.4
+
+- Fix [#217](https://github.com/kean/Pulse/issues/217): arithmetic overflow when the the number of deduplicated data links exceed the size limit 
+
 ## Pulse 4.0.3
 
 *Aug 27, 2023*

diff --git a/Sources/Pulse/LoggerStore/LoggerStore+Entities.swift b/Sources/Pulse/LoggerStore/LoggerStore+Entities.swift
@@ -289,7 +289,7 @@ public final class LoggerBlobHandleEntity: NSManagedObject {
     }
 
     /// A number of requests referencing it.
-    @NSManaged var linkCount: Int16
+    @NSManaged var linkCount: Int32
 
     /// The logger inlines small blobs in a separate table in the database which
     /// significantly [reduces](https://www.sqlite.org/intern-v-extern-blob.html)

diff --git a/Sources/Pulse/LoggerStore/LoggerStore+Model.swift b/Sources/Pulse/LoggerStore/LoggerStore+Model.swift
@@ -138,7 +138,7 @@ extension LoggerStore {
             Attribute(name: "key", type: .binaryDataAttributeType),
             Attribute(name: "size", type: .integer32AttributeType),
             Attribute(name: "decompressedSize", type: .integer32AttributeType),
-            Attribute(name: "linkCount", type: .integer16AttributeType),
+            Attribute(name: "linkCount", type: .integer32AttributeType),
             Attribute(name: "rawContentType", type: .stringAttributeType),
             Attribute(name: "inlineData", type: .binaryDataAttributeType),
             Attribute(name: "isUncompressed", type: .booleanAttributeType)