Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial implementation of deduceOp0 #87

Merged
merged 3 commits into from
Oct 31, 2023
Merged

feat: initial implementation of deduceOp0 #87

merged 3 commits into from
Oct 31, 2023

Conversation

lambda-0x
Copy link
Contributor

@lambda-0x lambda-0x commented Oct 30, 2023 •
edited
Loading

fixes: #45

TODO:

  • update comment documentation

@lambda-0x lambda-0x force-pushed the fix-45 branch 3 times, most recently from c60d180 to dfc4a55 Compare October 30, 2023 20:13
@lambda-0x lambda-0x changed the title feat: initial implementation of deduceOp1 feat: initial implementation of deduceOp0 Oct 30, 2023
@lambda-0x lambda-0x marked this pull request as ready for review October 30, 2023 20:15
tcoratger
tcoratger reviewed Oct 30, 2023
View reviewed changes
src/vm/core.zig Outdated Show resolved Hide resolved
src/vm/core.zig Outdated Show resolved Hide resolved
src/vm/core.zig Outdated Show resolved Hide resolved
src/vm/core_test.zig Outdated Show resolved Hide resolved
src/vm/core_test.zig Outdated Show resolved Hide resolved
src/vm/core.zig Outdated Show resolved Hide resolved
eightfilms
eightfilms reviewed Oct 31, 2023
View reviewed changes
src/vm/core.zig Outdated Show resolved Hide resolved
src/vm/core_test.zig Outdated Show resolved Hide resolved
@lambda-0x
Copy link
Contributor Author

some of suggestions mentioned by @tcoratger @bingcicle apply to deduceop1 as well, should i make those changes in this PR or make a PR for it after this is merged? @lana-shanghai

@AbdelStark
Copy link
Collaborator

some of suggestions mentioned by @tcoratger @bingcicle apply to deduceop1 as well, should i make those changes in this PR or make a PR for it after this is merged? @lana-shanghai

since those area of code are relatively close, you can proceed in the same PR @lambda-0x

@lambda-0x lambda-0x force-pushed the fix-45 branch 3 times, most recently from f9fd39e to dde2a22 Compare October 31, 2023 16:22
AbdelStark
AbdelStark approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit 6893672 into keep-starknet-strange:main Oct 31, 2023
4 checks passed
@github-actions GitHub Actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tcoratger tcoratger tcoratger left review comments

@eightfilms eightfilms eightfilms left review comments

@AbdelStark AbdelStark AbdelStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement deduce_op_0
4 participants
@lambda-0x @AbdelStark @eightfilms @tcoratger