Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling and Correct Minor Bugs in ActionsCRUD #2354

Closed
wants to merge 1 commit into from

Conversation

Anjalisharma8072
Copy link

This PR addresses several issues and optimizations within the ActionsCRUD class:

-Fixed typos in logging messages for better clarity.
-Corrected an inconsistent return statement in update_action, which previously returned the function itself instead of the updated action.
-Updated logging in _convert_models_to_dtos to handle cases where the Action model may not have a dict() method.
-Made exception handling more specific and provided clearer error messages, improving code robustness.
These changes enhance the reliability and readability of ActionsCRUD.

Copy link

vercel bot commented Oct 30, 2024

@Anjalisharma8072 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 30, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@talboren
Copy link
Member

Hey @Anjalisharma8072, thank you for this PR! May I kindly ask you to follow the PR guidelines and raise this PR again after there's a proper issue for it?

Thanks again!

@talboren talboren closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants