-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple alerts matching rules PoC #2727
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Skipped Deployment
|
a69f503
to
328620f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
===========================================
- Coverage 43.63% 30.99% -12.65%
===========================================
Files 162 71 -91
Lines 15789 7957 -7832
===========================================
- Hits 6890 2466 -4424
+ Misses 8899 5491 -3408 β View full report in Codecov by Sentry. |
f7a4a35
to
e68c23e
Compare
e68c23e
to
5bba42e
Compare
0cb2d9e
to
93bd91f
Compare
9192f13
to
837847e
Compare
β¦not enough to start and incident
837847e
to
dbc70c8
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8134198 | Triggered | Generic High Entropy Secret | c8b293a | keep-ui/app/frigade-provider.tsx | View secret |
14884154 | Triggered | Username Password | 3046854 | elk/docker-compose-elk.yml | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #2776
π Description
β Checks
βΉ Additional Information