Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple alerts matching rules PoC #2727

Merged
merged 31 commits into from
Dec 25, 2024

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented Dec 2, 2024

Closes #2776

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 25, 2024 8:18am

@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch 2 times, most recently from a69f503 to 328620f Compare December 7, 2024 14:06
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 24.57627% with 89 lines in your changes missing coverage. Please review.

Project coverage is 30.99%. Comparing base (6adf5bc) to head (44ce577).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
keep/rulesengine/rulesengine.py 21.79% 61 Missing ⚠️
keep/api/core/db.py 17.39% 19 Missing ⚠️
keep/api/bl/incidents_bl.py 20.00% 8 Missing ⚠️
keep/api/models/db/alert.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2727       +/-   ##
===========================================
- Coverage   43.63%   30.99%   -12.65%     
===========================================
  Files         162       71       -91     
  Lines       15789     7957     -7832     
===========================================
- Hits         6890     2466     -4424     
+ Misses       8899     5491     -3408     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@VladimirFilonov VladimirFilonov marked this pull request as ready for review December 8, 2024 18:19
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Feature A new feature labels Dec 8, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from f7a4a35 to e68c23e Compare December 8, 2024 18:21
@Matvey-Kuk Matvey-Kuk self-requested a review December 9, 2024 08:33
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from e68c23e to 5bba42e Compare December 10, 2024 05:26
@VladimirFilonov VladimirFilonov changed the title feat: PoC rules with historical data feat: multiple alerts matching rules PoC Dec 10, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from 0cb2d9e to 93bd91f Compare December 10, 2024 13:53
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 10, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from 9192f13 to 837847e Compare December 12, 2024 12:27
Matvey-Kuk
Matvey-Kuk previously approved these changes Dec 16, 2024
Matvey-Kuk
Matvey-Kuk previously approved these changes Dec 16, 2024
Copy link

gitguardian bot commented Dec 23, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret c8b293a keep-ui/app/frigade-provider.tsx View secret
14884154 Triggered Username Password 3046854 elk/docker-compose-elk.yml View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VladimirFilonov VladimirFilonov merged commit 0940902 into main Dec 25, 2024
11 of 14 checks passed
@VladimirFilonov VladimirFilonov deleted the feature/historical-rules-poc branch December 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: incidents to be created only when multiple alerts matches rule
3 participants