-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deduplication rules provisioning mechanism from KEEP_DEDUPLICATION_RULES env variable #2877
feat: Add deduplication rules provisioning mechanism from KEEP_DEDUPLICATION_RULES env variable #2877
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…oning-from-env-vars Signed-off-by: Ihor Panasiuk <[email protected]>
🫶 |
Signed-off-by: Vladimir Filonov <[email protected]> Co-authored-by: Shahar Glazner <[email protected]>
Signed-off-by: Shahar Glazner <[email protected]> Co-authored-by: Kirill Chernakov <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8134198 | Triggered | Generic High Entropy Secret | 6829326 | keep-ui/app/frigade-provider.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…oning-from-env-vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skynetigor we discussed in our call: we need to allow someone to both provision providers and provision deduplication rules based on the provisioned provider id. This should be done using the unique provisioning provider key.
…oning-from-env-vars Signed-off-by: Ihor Panasiuk <[email protected]>
…oning-from-env-vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 You're on fire, @skynetigor! Three PRs merged and counting! 🔥🎉 Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖 Remember, the team is always here to support you. Keep blazing that trail! 🚀 |
Closes #2872
📑 Description
Enable provisioning of deduplication rules during deployment through KEEP_DEDUPLICATION_RULES env variable
✅ Checks
ℹ Additional Information