Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deduplication rules provisioning mechanism from KEEP_DEDUPLICATION_RULES env variable #2877

Merged

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Dec 22, 2024

Closes #2872

📑 Description

Enable provisioning of deduplication rules during deployment through KEEP_DEDUPLICATION_RULES env variable

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 3:08pm

@shahargl
Copy link
Member

🫶

@skynetigor skynetigor marked this pull request as ready for review December 23, 2024 16:20
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Documentation Improvements or additions to documentation Feature A new feature labels Dec 23, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 23, 2024
Copy link

gitguardian bot commented Dec 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret 6829326 keep-ui/app/frigade-provider.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 23, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynetigor we discussed in our call: we need to allow someone to both provision providers and provision deduplication rules based on the provisioned provider id. This should be done using the unique provisioning provider key.

docs/mint.json Outdated Show resolved Hide resolved
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@talboren talboren enabled auto-merge (squash) December 24, 2024 15:08
@talboren talboren merged commit e268e33 into main Dec 24, 2024
10 of 13 checks passed
@talboren talboren deleted the feature/2872-add-deduplication-rules-provisioning-from-env-vars branch December 24, 2024 15:08
Copy link
Contributor

🎉 You're on fire, @skynetigor! Three PRs merged and counting! 🔥🎉

Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖
Have you considered taking on some more challenging issues? We'd love to see what you can do! 💪

Remember, the team is always here to support you. Keep blazing that trail! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Create Deduplication rule on provision
4 participants