Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add check for None in providers provisioning form env var #2896

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Dec 24, 2024

Closes #2897

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 3:22pm

@skynetigor skynetigor marked this pull request as ready for review December 24, 2024 15:21
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 43.40%. Comparing base (6adf5bc) to head (79a78c6).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
- Coverage   43.63%   43.40%   -0.24%     
==========================================
  Files         162      164       +2     
  Lines       15789    16067     +278     
==========================================
+ Hits         6890     6974      +84     
- Misses       8899     9093     +194     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@talboren talboren changed the title bugfix: Add check for None in providers provisioning form env var fix: Add check for None in providers provisioning form env var Dec 24, 2024
@talboren talboren enabled auto-merge (squash) December 24, 2024 15:36
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@talboren talboren merged commit 4256d64 into main Dec 24, 2024
14 of 18 checks passed
@talboren talboren deleted the fix_rules_provisioning_bug branch December 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ› Bug]: Error is thrown if KEEP_PROVIDERS env variable is not specified
2 participants