Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimization #2960

Closed
wants to merge 2 commits into from
Closed

feat: optimization #2960

wants to merge 2 commits into from

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Jan 1, 2025

No description provided.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 1, 2025
Copy link

vercel bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jan 1, 2025 10:13am

@dosubot dosubot bot added the Enhancement New feature or request label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Project coverage is 31.15%. Comparing base (3e3a0e6) to head (fa41f1e).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
keep/rulesengine/rulesengine.py 29.62% 19 Missing ⚠️
keep/api/core/db.py 10.00% 9 Missing ⚠️
keep/api/core/tenant_configuration.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2960       +/-   ##
===========================================
- Coverage   43.52%   31.15%   -12.37%     
===========================================
  Files         165       70       -95     
  Lines       16250     7905     -8345     
===========================================
- Hits         7073     2463     -4610     
+ Misses       9177     5442     -3735     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant