feat(perf): allow configuring search path #2952
Open
+139
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
feat/search_path
branch
from
6674ae9 to
d003bda
Compare
pdecat
commented
Dec 3, 2023
Comment on lines
+47
to
+49
| console.log(`configurationService.url: ${configurationService.url}`) | ||
| console.log(`configurationService.searchPath: ${configurationService.searchPath}`) | ||
| console.log(`params.rootUri: ${params.rootUri}`) |
There was a problem hiding this comment.
This helped a lot in understanding what was going on on startup.
TODO: remove this before merge if PR is accepted.
| } | ||
| }; | ||
| console.log(`rootUri: ${rootUri}`) |
There was a problem hiding this comment.
This helped a lot in understanding what was going on on startup.
TODO: remove this before merge if PR is accepted.
| @@ -58,18 +47,19 @@ export class VsCodeFileAccessor implements FileAccessor { | |||
| filelist: string[] = [], | |||
| ): string[] { | |||
| subFolder = path.normalize(subFolder); | |||
| console.log(`fileAccessor.tf:getFilesInFolder:subFolder: ${subFolder}`); | |||
There was a problem hiding this comment.
This helped a lot in understanding what was going on on startup.
TODO: remove this before merge if PR is accepted.
pdecat
force-pushed
the
feat/search_path
branch
from
d003bda to
143c343
Compare
pdecat
commented
Dec 3, 2023
pdecat
force-pushed
the
feat/search_path
branch
2 times, most recently
from
aca0091 to
387d315
Compare
|
Hi @keesschollaart81 @frenck, gentle ping :) |
pdecat
force-pushed
the
feat/search_path
branch
4 times, most recently
from
3252499 to
abf0a1c
Compare
pdecat
force-pushed
the
feat/search_path
branch
from
abf0a1c to
d1571a4
Compare
pdecat
force-pushed
the
feat/search_path
branch
from
d1571a4 to
deb9529
Compare
pdecat
force-pushed
the
feat/search_path
branch
from
deb9529 to
b4ba663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuring the path from which Home Assistant configuration files will be searched.
Empty by default, so all files in the workspace are still evaluated.
On large workspaces, setting this specifically to the path where configuration files are located can improve performance drastically. Path can be absolute or relative to the workspace root.
Also, I believe it resolves the 100% CPU usage and process not exiting after VSCode is closed behaviors reported several issues.