Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LONG_BIT to define RADIX_BITS #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use LONG_BIT to define RADIX_BITS #16

wants to merge 1 commit into from

Conversation

ffontaine
Copy link
Contributor

@ffontaine ffontaine commented Aug 4, 2024 •
edited
Loading

This allows to avoid having to support each CPU architecture individually.

Also, add the necessary defines in the makefile to expose LONG_BIT. Adding those defines end up requiring using <sys/select.h> as we're now using >= POSIX.1-2001 definitions of fd_set and friends.

@tpetazzoni @ffontaine
Use LONG_BIT to define RADIX_BITS
c3a3453 
This allows to avoid having to support each CPU architecture
individually.

Also, add the necessary defines in the makefile to expose
LONG_BIT. Adding those defines end up requiring using <sys/select.h>
as we're now using >= POSIX.1-2001 definitions of fd_set and friends.

Signed-off-by: Thomas Petazzoni <[email protected]>
Signed-off-by: Vincent Fazio <[email protected]>
Signed-off-by: Bernd Kuhls <[email protected]>
Signed-off-by: Fabrice Fontaine <[email protected]>
@ffontaine
Copy link
Contributor Author

This is a tentative to upstream this patch which has been applied on buildroot side since 2020: https://git.buildroot.net/buildroot/tree/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch

kgoldman
kgoldman reviewed Aug 6, 2024
View reviewed changes
Copy link
Owner

@kgoldman kgoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that this is Linux only, that the header file and macro don't exist on Windows and perhaps other platforms that are currently supported?

I like the idea, but I don't want to break non-Linux builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgoldman kgoldman kgoldman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffontaine @kgoldman @tpetazzoni