Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve readability of comments in solid/open_close.rb #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Improve readability of comments in solid/open_close.rb #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion solid/open_close.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ def parse_cvs

# Solution

# With this refactor we’ve made it possible to add new parsers without changing any code. Any additional behavior will only require the addition of a new handler. This makes our FileParser reusable and in many cases will keep us in compliance with the Single Responsibility Principle as well by encouraging us to create smaller more focused classes.
# With this refactor we’ve made it possible to add new parsers without changing any code.
# Any additional behavior will only require the addition of a new handler. This makes our
# FileParser reusable and in many cases will keep us in compliance with the
# Single Responsibility Principle as well by encouraging us to create smaller more focused classes.

class FileParser
attr_reader :parser
Expand Down