Ease of use and Base64 update #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kapp Category Attribute Definitions and Categories import was always deleting the values that existed on the destination server but not in the import data. Added the condition vars["options"]["delete"] && to the qualification of the delete
Added the import and export of v6 workflows. -Added the gem 'kinetic_sdk', '5.0.22' to dependencies
…ugh or selecting one. Updated main export.rb with selection changes. Updated Gemfile
… with writing encoded pwd
|
I think we should consider not writing the password to the file even if it is base64 encoded. Seems more like obfuscations vs any sort of security. I do like that the code looks for a pwd and uses if it is in the config. It gives the user the option if they don't care. That are your thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added logic to scan the config directory and list all configs based on a name pattern (export/import). I've also Base64 encoded passwords on config files. If they are plaintext they will be converted next time the config it utilized.