Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors open_new_blocks by lifting out handlers #506

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

digitalmoksha
Copy link
Collaborator

Another round of refactoring of the open_new_blocks function, lifting out the handlers.

@digitalmoksha digitalmoksha self-assigned this Dec 13, 2024
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-0402355 314.7 ± 3.6 311.8 330.5 2.83 ± 0.04
./bench.sh ./comrak-main 318.3 ± 3.8 315.7 335.7 2.87 ± 0.04
./bench.sh ./pulldown-cmark 111.1 ± 0.6 110.0 112.4 1.00
./bench.sh ./cmark-gfm 119.0 ± 0.8 118.1 120.7 1.07 ± 0.01
./bench.sh ./markdown-it 471.9 ± 1.5 469.3 476.0 4.25 ± 0.03

Run on Fri Dec 13 20:42:00 UTC 2024

@digitalmoksha
Copy link
Collaborator Author

I'm going to go ahead and optimistically merge this.

@digitalmoksha digitalmoksha merged commit 910bb50 into main Dec 14, 2024
39 checks passed
@digitalmoksha digitalmoksha deleted the bw-refactor-open-new-blocks-part-2 branch December 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant