-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Migrate off knative.dev/client-pkg #366
🧹 Migrate off knative.dev/client-pkg #366
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 55.67% 55.67%
=======================================
Files 51 51
Lines 1374 1374
=======================================
Hits 765 765
Misses 540 540
Partials 69 69 ☔ View full report in Codecov by Sentry. |
1dddad6
to
8795298
Compare
/test all |
/cc @dsimansk Looks like everything works as expected. I think we can go ahead with knative/client#1953 merge |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup
Tests knative/client#1953