Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Migrate off knative.dev/client-pkg #366

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 3, 2024

Changes

  • 🧹 Migrate off knative.dev/client-pkg

/kind cleanup

Tests knative/client#1953

Copy link

knative-prow bot commented Sep 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 3, 2024
@knative-prow knative-prow bot requested review from dsimansk and rhuss September 3, 2024 13:03
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2024
go.mod Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2024
@cardil
Copy link
Contributor Author

cardil commented Sep 3, 2024

/test all

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (364b92f) to head (71f9230).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   55.67%   55.67%           
=======================================
  Files          51       51           
  Lines        1374     1374           
=======================================
  Hits          765      765           
  Misses        540      540           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil force-pushed the chore/migrate-client-pkg branch from 1dddad6 to 8795298 Compare September 3, 2024 13:27
.golangci.yaml Outdated Show resolved Hide resolved
@cardil
Copy link
Contributor Author

cardil commented Sep 3, 2024

/test all

@cardil
Copy link
Contributor Author

cardil commented Sep 3, 2024

/cc @dsimansk

Looks like everything works as expected. I think we can go ahead with knative/client#1953 merge

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2024
@cardil cardil marked this pull request as ready for review September 3, 2024 14:34
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024
@dsimansk
Copy link
Contributor

dsimansk commented Sep 3, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link

knative-prow bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f9cb9aa into knative-extensions:main Sep 3, 2024
24 checks passed
@cardil cardil deleted the chore/migrate-client-pkg branch September 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants