Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gateway API for kind test #13710

Closed
wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Feb 16, 2023

As far as testing, the KinD test pases - https://github.com/nak3/serving/actions/runs/4190405898 with the current version.

Related to knative-extensions/net-gateway-api#275

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 86.17% // Head: 86.21% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (75a3598) compared to base (08812b3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13710      +/-   ##
==========================================
+ Coverage   86.17%   86.21%   +0.04%     
==========================================
  Files         197      197              
  Lines       14774    14774              
==========================================
+ Hits        12731    12737       +6     
+ Misses       1738     1735       -3     
+ Partials      305      302       -3     
Impacted Files Coverage Δ
pkg/activator/net/revision_backends.go 92.19% <0.00%> (-0.58%) ⬇️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️
pkg/autoscaler/statserver/server.go 77.37% <0.00%> (+3.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3
Copy link
Contributor Author

nak3 commented Feb 16, 2023

Umm... still flake remains. Closing for now.

@nak3 nak3 closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant