-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add resctrl qos collector #2005
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 67.19% 65.96% -1.23%
==========================================
Files 451 461 +10
Lines 43468 54190 +10722
==========================================
+ Hits 29208 35747 +6539
- Misses 11714 15876 +4162
- Partials 2546 2567 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rouzip <[email protected]>
Sorry for the late pr, any comments is welcome. |
Signed-off-by: Rouzip <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2d1efd6
to
c28c849
Compare
hello, PTAL 😊 @saintube |
Signed-off-by: Rouzip <[email protected]>
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged. |
😊 Anything I can do? |
We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the patch coverage to no less than the target of 70%. |
Signed-off-by: Rouzip <[email protected]>
Signed-off-by: Frame <[email protected]>
Signed-off-by: Frame <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL /cc @zwzhang0107 @hormes
"github.com/koordinator-sh/koordinator/pkg/koordlet/metriccache" | ||
"github.com/koordinator-sh/koordinator/pkg/koordlet/metrics" | ||
"github.com/koordinator-sh/koordinator/pkg/koordlet/metricsadvisor/framework" | ||
"github.com/koordinator-sh/koordinator/pkg/koordlet/qosmanager/plugins/resctrl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better not not import qos plugin
these const can be moved to utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The QoS of resctrl needs to align with that in qosmanager, so the qos plugin is imported.
Signed-off-by: Rouzip <[email protected]>
Ⅰ. Describe what this PR does
Add resctrl qos collector.
Ⅱ. Does this pull request fix one issue?
fixes #1832
Ⅲ. Describe how to verify it
After enable resctrl flag in config:
curl http://localhost:9316/metrics|grep resctrl
Ⅳ. Special notes for reviews
V. Checklist
make test