Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: rdma device inject #2285

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ferris-cx
Copy link
Contributor

@ferris-cx ferris-cx commented Nov 30, 2024

Ⅰ. Describe what this PR does

inject rdma uverbs device into Container

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (b36d230) to head (03b193f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oordlet/runtimehooks/protocol/container_context.go 0.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
- Coverage   66.07%   66.04%   -0.04%     
==========================================
  Files         454      454              
  Lines       53451    53463      +12     
==========================================
- Hits        35318    35307      -11     
- Misses      15593    15610      +17     
- Partials     2540     2546       +6     
Flag Coverage Δ
unittests 66.04% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng force-pushed the rdma-device-inject branch 2 times, most recently from 16036d9 to 9b97897 Compare December 4, 2024 07:16
@songtao98
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot merged commit ae367c4 into koordinator-sh:main Dec 4, 2024
22 checks passed
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants