Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth2-proxy readme for Keycloak #2934

Closed
wants to merge 1 commit into from

Conversation

juliusvonkohout
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...
#2931 (comment)

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: Julius von Kohout <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from juliusvonkohout. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout changed the title Update README.md Update oauth2-proxy readme for Keycloak Dec 16, 2024
@juliusvonkohout
Copy link
Member Author

https://cloud-native.slack.com/archives/C073W572LA2/p1733818844895669
Hailey are you sure about
skip_auth_routes = [
"^/oauth2/callback",
]
? Please test again and review / comment on #2934

@juliusvonkohout
Copy link
Member Author

CC @kromanow94

@juliusvonkohout
Copy link
Member Author

"@Julius von Kohout
I tried removing that line but it still worked. When I first tried without this, I couldn't access to the dashboard, but this time I could without it. I'm not sure it is the thing that really matters. I figured I should find other factors."

@juliusvonkohout juliusvonkohout deleted the juliusvonkohout-patch-1 branch December 16, 2024 08:21
@kromanow94
Copy link
Contributor

Just a hunch - maybe it was connected to Istio where it needs some time to refresh it's settings from the cache and populate to the istio-proxy containers (or istio-cni). This action is done by istiod. I usually give it like 10 seconds before testing changes in configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants