-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove patching of istio; update values for seccompvalue via chart #2938
base: istio-cni-by-default-with-seccomp-value
Are you sure you want to change the base?
Remove patching of istio; update values for seccompvalue via chart #2938
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am on my phone, so there might be small mistakes. |
values: | ||
defaultRevision: "" | ||
gateways: | ||
istio-egressgateway: {} | ||
istio-ingressgateway: {} | ||
seccompProfile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to replace the patches?
You have to sign your commits to satisfy the DCO |
/ok-to-test |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
We should use the new "Values.gateways.seccompProfile" and securitycontext to get rid of the manual patch at
manifests/.github/workflows/pss_test.yaml
Lines 35 to 45 in 26d970d
both for istio and istio-cni, so it is related to #2528
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCO
check)