Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add securitycontext for PSS PoC (rootless Kubeflow) #2939

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

biswassri
Copy link

@biswassri biswassri commented Dec 20, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

Adding PSS enforceable for sso and oauth2-proxy and enjoy a rootless Kubeflow #2528

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link
Member

@juliusvonkohout juliusvonkohout Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an upstream file. Please do not modify it, but instead our DEX at https://github.com/kubeflow/manifests/tree/master/common/dex

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll update this.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kromanow94, yanniszark for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: biswassri <[email protected]>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Dec 21, 2024

We also need to remove the two patches from /contrib/security then if we apply them always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants