-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csi): add CSI manifests #491
feat(csi): add CSI manifests #491
Conversation
Signed-off-by: Alessio Pragliola <[email protected]>
/lgtm cc @lampajr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Al-Pragliola! 🚀
/lgtm
/approve
Note for release strategy #435 pushd manifests/kustomize/options/csi && kustomize edit set image kubeflow/model-registry-storage-initializer=kubeflow/model-registry-storage-initializer:v0.2.9 && popd thanks a lot for the contribution @Al-Pragliola 🚀 next step: sync KF/manifests, so eventually also this can be referenced from the next MR release synced! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adapts kubeflow#491 Signed-off-by: Matteo Mortari <[email protected]>
Description
Added manifests for CSI deployment, the following:
cannot be parameterized as an env from configmap because the way kserve works is to use it as a template for an initcontainer that is injected into the serving deployment, so it has to be viewed as a fallback URL to reach the default model registry.
How Has This Been Tested?
docker build . -f Dockerfile -t mr/mr:0.1.1 LOCAL=1 IMG=mr/mr:0.1.1 ./scripts/deploy_on_kind.sh
then followed the guide from csi/GET_STARTED.md
Merge criteria:
DCO
check)