Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csi): add CSI manifests #491

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Oct 21, 2024

Description

Added manifests for CSI deployment, the following:

    - name: MODEL_REGISTRY_BASE_URL
      value: "model-registry-service.kubeflow.svc.cluster.local:8080"

cannot be parameterized as an env from configmap because the way kserve works is to use it as a template for an initcontainer that is injected into the serving deployment, so it has to be viewed as a fallback URL to reach the default model registry.

How Has This Been Tested?

docker build . -f Dockerfile -t mr/mr:0.1.1
LOCAL=1 IMG=mr/mr:0.1.1 ./scripts/deploy_on_kind.sh

then followed the guide from csi/GET_STARTED.md

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Signed-off-by: Alessio Pragliola <[email protected]>
@tarilabs
Copy link
Member

it has to be viewed as a fallback URL to reach the default model registry.

/lgtm

cc @lampajr

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Al-Pragliola! 🚀

/lgtm
/approve

@tarilabs
Copy link
Member

Note for release strategy #435
for pinning the version in the manifest while releasing

pushd manifests/kustomize/options/csi && kustomize edit set image kubeflow/model-registry-storage-initializer=kubeflow/model-registry-storage-initializer:v0.2.9 && popd

ref also https://github.com/opendatahub-io/model-registry/wiki/Notes-on-Releasing-Upstream,-Midstream-model%E2%80%90registry/_compare/7c4b82724a1d66a0113589bd45ed9c25e57412eb


thanks a lot for the contribution @Al-Pragliola 🚀 next step: sync KF/manifests, so eventually also this can be referenced from the next MR release synced!

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cf59057 into kubeflow:main Oct 22, 2024
17 checks passed
@Al-Pragliola Al-Pragliola deleted the feat/csi-manifests branch October 22, 2024 16:52
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Oct 28, 2024
adapts kubeflow#491

Signed-off-by: Matteo Mortari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants